Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up signal handling #2325

Merged
merged 6 commits into from
Apr 11, 2018
Merged

Conversation

theoreticalbts
Copy link
Contributor

This PR is a fairly self explanatory refactoring. Here are the main features:

  • Rename signals and related methods to be descriptive and consistent
  • Always use an XXX_notification struct as the signal argument (simplifies code changes needed to send more data to a signal handler)
  • Add pre-apply signal for blocks
  • Always use groups (allows control of processing order when needed, so some plugins' handlers can depend on the results of other handlers)
  • Remove unused handler (its functionality is now available by checking whether or not you're currently processing a block)

@mvandeberg
Copy link
Contributor

Closes #2230

Copy link
Contributor

@mvandeberg mvandeberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was much needed. LGTM

@mvandeberg mvandeberg merged commit ab3bc5e into develop Apr 11, 2018
@mvandeberg mvandeberg deleted the 2018-04-11-cleanup-signal-handling branch April 11, 2018 16:10
@mvandeberg mvandeberg mentioned this pull request Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants