Move broadcast_transaction_synchronous to condenser_api

[mvandeberg]

Closes #2278

[theoreticalbts]

Merge conflict in network_broadcast_api.cpp. Also, I'm pretty sure this will not compile since #2325 was merged.

[mvandeberg]

Will look into it.

[mvandeberg]

@theoreticalbts Conflicts have been resolved.

[theoreticalbts]

It looks suspicious that the API call implementation parses code as legacy_signed_transaction, but the cli_wallet remote API declaration says signed_transaction.

Has cli_wallet transaction broadcast been tested?

Also, minor nitpick: Signal field/method are named on_applied_block, _on_applied_block_connection. But the signal refactoring standardized those names to on_post_apply_block, _post_apply_block_conn.

[mvandeberg]

I'll double check the wallet.

We need to document such naming conventions. I noticed that there was some renaming because of the changed signal names, but I guess I did not notice the standardization of the names. I can make the change.

[theoreticalbts]

Approved