Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow latest version check to take retries arg #890

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

andrjohns
Copy link
Collaborator

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

Addresses #889

Allows the latest_released_version() function to pass-through arguments to the download_with_retries() function. This is to avoid the latest version check from retrying 5 times on package load when the user does not have internet access (or a similar firewall issue)

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Andrew Johnson

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@andrjohns andrjohns merged commit 48a2b3e into master Dec 21, 2023
12 checks passed
@andrjohns andrjohns deleted the version-check-failfast branch December 21, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants