Merge pull request #890 from stan-dev/version-check-failfast

Allow latest version check to take retries arg
stan-dev · Dec 21, 2023 · 48a2b3e · 48a2b3e
2 parents abc5f39 + d6b628b
commit 48a2b3e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/R/install.R b/R/install.R
@@ -398,10 +398,10 @@ github_download_url <- function(version_number) {
 }
 
 # get version number of latest release
-latest_released_version <- function(quiet=TRUE) {
+latest_released_version <- function(quiet=TRUE, ...) {
   dest_file <- tempfile(pattern = "releases-", fileext = ".json")
   download_url <- "https://api.github.com/repos/stan-dev/cmdstan/releases/latest"
-  release_list_downloaded <- download_with_retries(download_url, dest_file, quiet = quiet)
+  release_list_downloaded <- download_with_retries(download_url, dest_file, quiet = quiet, ...)
   if (inherits(release_list_downloaded, "try-error")) {
     stop("GitHub download of release list failed with error: ",
         attr(release_list_downloaded, "condition")$message,

diff --git a/R/zzz.R b/R/zzz.R
@@ -14,7 +14,7 @@ startup_messages <- function() {
     default = identical(tolower(Sys.getenv("CMDSTANR_NO_VER_CHECK")), "true")
   ))
   if (!skip_version_check) {
-    latest_version <- try(suppressWarnings(latest_released_version()), silent = TRUE)
+    latest_version <- try(suppressWarnings(latest_released_version(retries = 0)), silent = TRUE)
     current_version <- try(cmdstan_version(), silent = TRUE)
     if (!inherits(latest_version, "try-error")
         && !inherits(current_version, "try-error")