zed: automate Kolla Ansible tag variable definitions #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markgoddard
changed the title
markgoddard
force-pushed
the
zed-auto-tags
branch
from
4bb1c8f to
80af037
Compare
jovial
reviewed
Sep 27, 2023
markgoddard
force-pushed
the
zed-auto-tags
branch
6 times, most recently
from
071ba56 to
66c8335
Compare
priteau
requested changes
Jan 29, 2024
This will make it easier to automate various tasks.
We no longer require it since Ironic dropped the iscsi deploy driver.
No more forgotten image promotions!
Use the new kolla-images.py script to automatically define tag variables in globals.yml based on the tags that are defined in kolla_image_tags.
markgoddard
force-pushed
the
zed-auto-tags
branch
from
66c8335 to
4e90858
Compare
The previous tag was not in Ark, but this one is present.
The failing case was the haproxy image used by the neutron_tls_proxy container, if a tag is defined for the 'neutron' prefix but not 'haproxy'.
jovial
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reworks the way that Kolla image tags are defined, making the following improvements possible:
The main visible change is that container image tags are now defined in the kolla_image_tags variable in etc/kayobe/kolla-image-tags.yml. This avoids the previous churn in the etc/kayobe/kolla/globals.yml file.
A new script, tools/kolla-images.py, understands the Kolla image and container relationships, and is able to display the tags used by each image. This output is parsed in the new container promotion workflows added in stackhpc/stackhpc-release-train#193.