Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zed: Update to Rocky 9.3 based kolla images #908

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

jovial
Copy link
Contributor

@jovial jovial commented Feb 2, 2024

@jovial jovial requested a review from a team as a code owner February 2, 2024 13:41
@jovial jovial changed the title Zed: Rebuild Rocky Images Zed: Update to Rocky 9.3 based kolla images Feb 2, 2024
Comment on lines 18 to 30
rocky: zed-rocky-9-20230927T142529
ubuntu: zed-ubuntu-jammy-20230927T154443
ovn:
rocky: zed-rocky-9-20230925T132313
ubuntu: zed-ubuntu-jammy-20230821T155947
cloudkitty:
rocky: zed-rocky-9-20231114T124701
ubuntu: zed-ubuntu-jammy-20231114T124701
neutron:
rocky: zed-rocky-9-20231115T094053
ubuntu: zed-ubuntu-jammy-20231115T094053
opensearch:
rocky: zed-rocky-9-20231214T095452
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing these lines will cause the tag lookup (lines 34-38) to break. I think in the past we've resolved this by either just duplicating the tag, or adding a default value to the lookup

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If only we had merged #663 already we wouldn't need to worry about this :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers, I've add the default value.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If only we had merged #663 already we wouldn't need to worry about this :D

Should we try and get that merged instead?

ubuntu: zed-ubuntu-jammy-20231115T094053
opensearch:
rocky: zed-rocky-9-20231214T095452
ubuntu: zed-ubuntu-jammy-20231214T095452

openstack_tag: "{% raw %}{{ kayobe_image_tags['openstack'][kolla_base_distro] }}{% endraw %}"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, no default on these now :(

@jovial jovial force-pushed the feature/zed/rocky9.3-kolla-images branch from 0688e35 to bd74843 Compare February 2, 2024 13:51
These have been rebuilt using Rocky 9.3 snapshots.
@jovial jovial force-pushed the feature/zed/rocky9.3-kolla-images branch from bd74843 to 6a2f89b Compare February 2, 2024 13:51
@jovial jovial closed this Feb 2, 2024
@jovial jovial reopened this Feb 2, 2024
@markgoddard markgoddard merged commit d2e457d into stackhpc/zed Feb 5, 2024
12 checks passed
@markgoddard markgoddard deleted the feature/zed/rocky9.3-kolla-images branch February 5, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants