Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Document and clarify vector graceful shutdown #681

Merged
merged 15 commits into from
Oct 31, 2023
Merged

feat: Document and clarify vector graceful shutdown #681

merged 15 commits into from
Oct 31, 2023

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Oct 27, 2023 •
edited by siegfriedweber
Loading

Description

Part of stackabletech/issues#357
Needed for stackabletech/hdfs-operator#407

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Preview Give feedback

Reviewer
Preview Give feedback

Acceptance
Preview Give feedback

@sbernauer sbernauer mentioned this pull request Oct 27, 2023
Closed
@sbernauer sbernauer self-assigned this Oct 27, 2023
@sbernauer sbernauer mentioned this pull request Oct 27, 2023
Merged
@sbernauer sbernauer force-pushed the docs/vector-process branch from de92d72 to 23a4ac0 Compare October 27, 2023 13:50
@siegfriedweber siegfriedweber self-requested a review October 30, 2023 10:04
siegfriedweber
siegfriedweber requested changes Oct 30, 2023
View reviewed changes
src/product_logging/framework.rs Outdated Show resolved Hide resolved
src/utils.rs Outdated Show resolved Hide resolved
siegfriedweber
siegfriedweber approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbernauer sbernauer enabled auto-merge October 31, 2023 10:25
@sbernauer sbernauer added this pull request to the merge queue Oct 31, 2023
Merged via the queue into main with commit 45a544d Oct 31, 2023
16 checks passed
@sbernauer sbernauer deleted the docs/vector-process branch October 31, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siegfriedweber siegfriedweber siegfriedweber approved these changes

Assignees

@sbernauer sbernauer

Labels
None yet
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbernauer @siegfriedweber