Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support graceful shutdown #407

Merged
merged 34 commits into from
Nov 2, 2023
Merged

feat: Support graceful shutdown #407

merged 34 commits into from
Nov 2, 2023

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Oct 11, 2023 •
edited
Loading

Description

Part of stackabletech/issues#357
Closes #406
Needs stackabletech/operator-rs#681

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Preview Give feedback

Reviewer
Preview Give feedback

Acceptance
Preview Give feedback

@sbernauer sbernauer self-assigned this Oct 11, 2023
@sbernauer sbernauer mentioned this pull request Oct 11, 2023
Closed
@sbernauer
Copy link
Member Author

https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/hdfs-operator-it-custom/101/

Techassi
Techassi requested changes Oct 12, 2023
View reviewed changes
rust/crd/src/lib.rs Outdated Show resolved Hide resolved
rust/operator/src/operations/graceful_shutdown.rs Outdated Show resolved Hide resolved
@Techassi Techassi mentioned this pull request Oct 12, 2023
Merged
@sbernauer sbernauer mentioned this pull request Oct 13, 2023
Merged
@sbernauer
Copy link
Member Author

@nightkr @Techassi all review comments should be addressed, please have a look!

@sbernauer sbernauer requested review from Techassi and nightkr October 18, 2023 12:55
nightkr
nightkr previously approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@nightkr nightkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with deferring the docs nits to a separate issue

Techassi
Techassi requested changes Oct 19, 2023
View reviewed changes
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final nit :)

rust/operator/src/hdfs_controller.rs Outdated Show resolved Hide resolved
@sbernauer sbernauer requested a review from Techassi October 19, 2023 13:59
Techassi
Techassi previously approved these changes Oct 20, 2023
View reviewed changes
@sbernauer sbernauer mentioned this pull request Oct 27, 2023
Merged
siegfriedweber
siegfriedweber approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbernauer
Copy link
Member Author

Final test run: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/hdfs-operator-it-custom/107/

@sbernauer
Copy link
Member Author

Tests passed 🚀

@sbernauer sbernauer added this pull request to the merge queue Nov 2, 2023
Merged via the queue into main with commit dad96db Nov 2, 2023
29 checks passed
@sbernauer sbernauer deleted the feat/graceful-shutdown-2 branch November 2, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razvan razvan razvan left review comments

@siegfriedweber siegfriedweber siegfriedweber approved these changes

@nightkr nightkr nightkr left review comments

@Jimvin Jimvin Awaiting requested review from Jimvin

@Techassi Techassi Awaiting requested review from Techassi

Assignees

@sbernauer sbernauer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support graceful shutdown
6 participants
@sbernauer @razvan @nightkr @Jimvin @Techassi @siegfriedweber