Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support graceful shutdown #407

Merged
merged 34 commits into from
Nov 2, 2023

Merge remote-tracking branch 'origin/main' into feat/graceful-shutdown-2

23d52c9
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

feat: Support graceful shutdown #407

Merge remote-tracking branch 'origin/main' into feat/graceful-shutdown-2
23d52c9
Select commit
Loading
Failed to load commit list.
GitHub Actions / LanguageTool completed Oct 27, 2023 in 1s

reviewdog [LanguageTool] report

reported by reviewdog 🐶

Findings (1)

docs/modules/hdfs/pages/usage-guide/operations/graceful-shutdown.adoc|18 col 30| Possible agreement error. The noun ‘server’ seems to be countable. (CD_NN[1])
Suggestions: servers
Rule: https://community.languagetool.org/rule/show/CD_NN?lang=en-US&subId=1
Category: GRAMMAR

Filtered Findings (23)

.github/pull_request_template.md|16 col 36| This expression is normally spelled as one or with a hyphen. (EN_COMPOUNDS)
Suggestions: non-trivial, nontrivial
URL: https://languagetool.org/insights/post/hyphen/
Rule: https://community.languagetool.org/rule/show/EN_COMPOUNDS?lang=en-US
Category: MISC
README.md|61 col 19| It appears that hyphens are missing in the adjective “up-to-date”. (UP_TO_DATE_HYPHEN[2])
Suggestions: up-to-date
URL: https://languagetool.org/insights/post/hyphen/#hyphenated-phrases-with-more-than-one-hyphen
Rule: https://community.languagetool.org/rule/show/UP_TO_DATE_HYPHEN?lang=en-US&subId=2
Category: COMPOUNDING
docs/modules/hdfs/pages/getting_started/first_steps.adoc|3 col 193| In American English, ‘afterward’ is the preferred variant. ‘Afterwards’ is more commonly used in British English and other dialects. (AFTERWARDS_US[1])
Suggestions: Afterward
Rule: https://community.languagetool.org/rule/show/AFTERWARDS_US?lang=en-US&subId=1
Category: BRITISH_ENGLISH
docs/modules/hdfs/pages/getting_started/index.adoc|16 col 2| Insert a space between the numerical value and the unit symbol. (UNIT_SPACE[1])
Suggestions: 256 MB
Rule: https://community.languagetool.org/rule/show/UNIT_SPACE?lang=en-US&subId=1
Category: PUNCTUATION
docs/modules/hdfs/pages/index.adoc|15 col 1| In American English, ‘afterward’ is the preferred variant. ‘Afterwards’ is more commonly used in British English and other dialects. (AFTERWARDS_US[1])
Suggestions: Afterward
Rule: https://community.languagetool.org/rule/show/AFTERWARDS_US?lang=en-US&subId=1
Category: BRITISH_ENGLISH
docs/modules/hdfs/pages/usage-guide/configuration-environment-overrides.adoc|87 col 1| Consider replacing this phrase with the adverb “similarly” to avoid wordiness. (IN_A_X_MANNER[2])
Suggestions: Similarly
Rule: https://community.languagetool.org/rule/show/IN_A_X_MANNER?lang=en-US&subId=2
Category: REDUNDANCY
docs/modules/hdfs/pages/usage-guide/fuse.adoc|77 col 23| Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: simple-hdfs
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
docs/modules/hdfs/pages/usage-guide/monitoring.adoc|5 col 14| Consider using “except” or “except for” (WITH_THE_EXCEPTION_OF[1])
Suggestions: except, except for
URL: https://languagetool.org/insights/post/wordiness/
Rule: https://community.languagetool.org/rule/show/WITH_THE_EXCEPTION_OF?lang=en-US&subId=1
Category: REDUNDANCY
docs/modules/hdfs/pages/usage-guide/resources.adoc|74 col 3| Insert a space between the numerical value and the unit symbol. (UNIT_SPACE[1])
Suggestions: 2950 m
Rule: https://community.languagetool.org/rule/show/UNIT_SPACE?lang=en-US&subId=1
Category: PUNCTUATION
docs/modules/hdfs/pages/usage-guide/resources.adoc|75 col 3| Insert a space between the numerical value and the unit symbol. (UNIT_SPACE[1])
Suggestions: 8300 m
Rule: https://community.languagetool.org/rule/show/UNIT_SPACE?lang=en-US&subId=1
Category: PUNCTUATION
docs/modules/hdfs/pages/usage-guide/resources.adoc|76 col 3| Insert a space between the numerical value and the unit symbol. (UNIT_SPACE[1])
Suggestions: 6528 m
Rule: https://community.languagetool.org/rule/show/UNIT_SPACE?lang=en-US&subId=1
Category: PUNCTUATION
docs/modules/hdfs/pages/usage-guide/resources.adoc|88 col 15| Insert a space between the numerical value and the unit symbol. (UNIT_SPACE[1])
Suggestions: 100 m
Rule: https://community.languagetool.org/rule/show/UNIT_SPACE?lang=en-US&subId=1
Category: PUNCTUATION
docs/modules/hdfs/pages/usage-guide/resources.adoc|89 col 15| Insert a space between the numerical value and the unit symbol. (UNIT_SPACE[1])
Suggestions: 400 m
Rule: https://community.languagetool.org/rule/show/UNIT_SPACE?lang=en-US&subId=1
Category: PUNCTUATION
docs/modules/hdfs/pages/usage-guide/resources.adoc|99 col 15| Insert a space between the numerical value and the unit symbol. (UNIT_SPACE[1])
Suggestions: 250 m
Rule: https://community.languagetool.org/rule/show/UNIT_SPACE?lang=en-US&subId=1
Category: PUNCTUATION
docs/modules/hdfs/pages/usage-guide/resources.adoc|100 col 15| Insert a space between the numerical value and the unit symbol. (UNIT_SPACE[1])
Suggestions: 1000 m
Rule: https://community.languagetool.org/rule/show/UNIT_SPACE?lang=en-US&subId=1
Category: PUNCTUATION
docs/modules/hdfs/pages/usage-guide/resources.adoc|110 col 15| Insert a space between the numerical value and the unit symbol. (UNIT_SPACE[1])
Suggestions: 100 m
Rule: https://community.languagetool.org/rule/show/UNIT_SPACE?lang=en-US&subId=1
Category: PUNCTUATION
docs/modules/hdfs/pages/usage-guide/resources.adoc|111 col 15| Insert a space between the numerical value and the unit symbol. (UNIT_SPACE[1])
Suggestions: 400 m
Rule: https://community.languagetool.org/rule/show/UNIT_SPACE?lang=en-US&subId=1
Category: PUNCTUATION
docs/modules/hdfs/pages/usage-guide/security.adoc|5 col 63| You should probably use “need”. (AGREEMENT_SENT_START[17])
Suggestions: need
Rule: https://community.languagetool.org/rule/show/AGREEMENT_SENT_START?lang=en-US&subId=17
Category: GRAMMAR
docs/modules/hdfs/pages/usage-guide/security.adoc|11 col 124| A comma may be missing after the conjunctive/linking adverb ‘Additionally’. (SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA[1])
Suggestions: Additionally,
URL: https://languagetool.org/insights/post/linking-words/
Rule: https://community.languagetool.org/rule/show/SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA?lang=en-US&subId=1
Category: PUNCTUATION
docs/modules/hdfs/pages/usage-guide/security.adoc|12 col 72| Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: create
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
docs/modules/hdfs/pages/usage-guide/security.adoc|14 col 35| In American English, ‘afterward’ is the preferred variant. ‘Afterwards’ is more commonly used in British English and other dialects. (AFTERWARDS_US[1])
Suggestions: Afterward
Rule: https://community.languagetool.org/rule/show/AFTERWARDS_US?lang=en-US&subId=1
Category: BRITISH_ENGLISH
docs/modules/hdfs/pages/usage-guide/security.adoc|54 col 8| Use “a” instead of ‘an’ if the following word doesn’t start with a vowel sound, e.g. ‘a sentence’, ‘a university’. (EN_A_VS_AN)
Suggestions: a
URL: https://languagetool.org/insights/post/indefinite-articles/
Rule: https://community.languagetool.org/rule/show/EN_A_VS_AN?lang=en-US
Category: MISC
tests/README-templating.md|63 col 101| Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short). (COMMA_COMPOUND_SENTENCE[1])
Suggestions: , and
URL: https://languagetool.org/insights/post/grammar-what-are-compound-sentences/
Rule: https://community.languagetool.org/rule/show/COMMA_COMPOUND_SENTENCE?lang=en-US&subId=1
Category: PUNCTUATION

Annotations

Check notice on line 18 in docs/modules/hdfs/pages/usage-guide/operations/graceful-shutdown.adoc

See this annotation in the file changed.

@github-actions github-actions / LanguageTool

[LanguageTool] docs/modules/hdfs/pages/usage-guide/operations/graceful-shutdown.adoc#L18

Possible agreement error. The noun ‘server’ seems to be countable. (CD_NN[1])
Suggestions: `servers`
Rule: https://community.languagetool.org/rule/show/CD_NN?lang=en-US&subId=1
Category: GRAMMAR
Raw output
docs/modules/hdfs/pages/usage-guide/operations/graceful-shutdown.adoc:18:30: Possible agreement error. The noun ‘server’ seems to be countable. (CD_NN[1])
 Suggestions: `servers`
 Rule: https://community.languagetool.org/rule/show/CD_NN?lang=en-US&subId=1
 Category: GRAMMAR