Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added-late_CI_FIXES #117

Merged
merged 3 commits into from
May 18, 2023
Merged

added-late_CI_FIXES #117

merged 3 commits into from
May 18, 2023

Conversation

mixmix
Copy link
Member

@mixmix mixmix commented May 18, 2023 •
edited
Loading

Wanted to get this passing reliably. Also changes replicate to "replicate all" by default.

The function I wrote goes through each pair of peers in a set (with repetition). Turns our the repetition doesn't cost anything to do, because the vector clock check is so dang fast

alice-bob   ▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨ 3279ms
alice-carol ▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨ 4147ms
alice-david ▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨ 5414ms
bob-alice   ▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨ 5385ms
bob-carol   ▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨ 5374ms
bob-david   ▨ 28ms
carol-alice ▨ 11ms
carol-bob   ▨ 6ms
carol-david ▨ 6ms
david-alice ▨ 5ms
david-bob   ▨ 5ms
david-carol ▨ 8ms
  • see alice-david is slow the first time, but david-alice later is almost instantaneous.
  • interestingly alice-bob and bob-alice are both slow ... this is because in between these alice has picked up more feeds from carol and david (I think?)

@mixmix
Tweaks for CI
0daab96 
Squashed commit of the following:

commit 770f283
Author: mix irving <[email protected]>
Date:   Thu May 18 14:54:09 2023 +1200

    blah

commit 9e76b8e
Author: mix irving <[email protected]>
Date:   Thu May 18 14:39:01 2023 +1200

    rm ssb-caps, use randomBytes, add timeout for final test

commit ffc89c4
Author: mix irving <[email protected]>
Date:   Thu May 18 14:16:09 2023 +1200

    disable legacy-replication

commit 61ad664
Author: mix irving <[email protected]>
Date:   Thu May 18 10:38:11 2023 +1200

    add licenses to new files

commit 38e8eeb
Author: mix irving <[email protected]>
Date:   Thu May 18 10:36:35 2023 +1200

    add legacyReplication

commit 3dc4eb6
Author: mix irving <[email protected]>
Date:   Thu May 18 10:16:55 2023 +1200

    fixups

commit 5dacf0a
Author: mix irving <[email protected]>
Date:   Thu May 18 09:54:41 2023 +1200

    tests: log for when ebt fails to replicate

commit 25d5c0f
Author: Jacob Karlsson <[email protected]>
Date:   Fri May 12 12:12:46 2023 +0200

    1.0.1

commit 8c896ad
Author: Jacob Karlsson <[email protected]>
Date:   Fri May 12 12:12:34 2023 +0200

    Include all lib files in module

commit 0714473
Author: Jacob Karlsson <[email protected]>
Date:   Fri May 12 11:52:42 2023 +0200

    1.0.0
@mixmix mixmix changed the title Tweaks for CI added-late_CI_FIXES May 18, 2023
@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Deprecated license ✅ 0 issues
Missing license ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

🚮 Removed packages: [email protected]

@mixmix mixmix force-pushed the added-late_CI_FIXES branch from 20ccc90 to c76ead4 Compare May 18, 2023 04:40
@mixmix mixmix force-pushed the added-late_CI_FIXES branch from 8567e84 to 4c42d82 Compare May 18, 2023 04:59
This was referenced May 18, 2023
Merged
Closed
@mixmix mixmix requested a review from Powersource May 18, 2023 05:10
Powersource
Powersource reviewed May 18, 2023
View reviewed changes
test/helpers/replicate.js
Comment on lines 67 to 70
const clocks = await Promise.all([
p(person1.getVectorClock)(),
p(person2.getVectorClock)(),
])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This replicate function will probably have the same bug that we ran into in #106 (comment)

I think this might break if it's bob that creates the group.

Powersource
Powersource reviewed May 18, 2023
View reviewed changes
test/helpers/replicate.js
@@ -45,21 +85,8 @@ function setupFeedRequests(person1, person2) {
]),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"This is the list of feedIds that we should care about in our vector clock" mix says

@Powersource Powersource merged commit 5c33a1f into added-late May 18, 2023
@Powersource Powersource deleted the added-late_CI_FIXES branch May 18, 2023 15:23
@Powersource
Copy link
Collaborator

added a comment to replicate in the other pr after merging

@staltz
Copy link
Member

staltz commented May 19, 2023

alice-bob ▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨ 3279ms

All I can think of is how cute these boxes are.

@mixmix
Copy link
Member Author

mixmix commented May 22, 2023

haha @staltz I see you're also a fan of command line logging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Powersource Powersource Powersource left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mixmix @Powersource @staltz