People added late to a group should get access to all epochs #106

Powersource · 2023-05-04T14:35:44Z

Fixes #76

add-member people to all tip epochs
test that we add to all epoch tips
test that a late added member can read old stuff
send added people all old secrets as well
when joining a group, grab all tip invites (maybe we do already?) and all the secrets in them
check that we send the right secrets
update addMembers readme
did we put/plan to put this in one of the specs? mix? check for issue/task. yeah mix seems to have a task
add a comment to replicate about it breaking when people have secret feeds from someone else

Powersource · 2023-05-04T18:29:55Z

interesting error

# create reuses a group feed that hasn't had members yet (because of an earlier crash or something)
ok 17 got root
ok 18 there are no group feeds yet
ok 19 there is 1 group feed after we created a group
ok 20 there is 1 used group feed and 1 we created now with a root message but not ourselves as a member
fail create Error: Failed to add myself to the group when creating a group
    at /home/me/prj/ssb/ssb-tribes2/index.js:100:30
    at /home/me/prj/ssb/ssb-tribes2/index.js:156:29
  Error: todo
    at /home/me/prj/ssb/ssb-tribes2/index.js:156:32
    at /home/me/prj/ssb/ssb-tribes2/lib/epochs.js:109:25
  Error: Failed to resolve epoch @tangle/reduce
    at /home/me/prj/ssb/ssb-tribes2/lib/epochs.js:109:28
    at /home/me/prj/ssb/ssb-tribes2/lib/epochs.js:243:16
  Error: Malformed group/init root message
    at /home/me/prj/ssb/ssb-tribes2/lib/epochs.js:244:11
  Error
    at /home/me/prj/ssb/ssb-tribes2/lib/epochs.js:245:13
    at /home/me/prj/ssb/ssb-tribes2/node_modules/.pnpm/[email protected]/node_modules/ssb-db2/core.js:251:22
    at /home/me/prj/ssb/ssb-tribes2/node_modules/.pnpm/[email protected]/node_modules/ssb-db2/core.js:271:7
    at /home/me/prj/ssb/ssb-tribes2/node_modules/.pnpm/[email protected]/node_modules/ssb-db2/log.js:109:9
    at gotBlock (/home/me/prj/ssb/ssb-tribes2/node_modules/.pnpm/[email protected]/node_modules/async-append-only-log/index.js:255:7)
    at getBlock (/home/me/prj/ssb/ssb-tribes2/node_modules/.pnpm/[email protected]/node_modules/async-append-only-log/index.js:233:7)
    at get (/home/me/prj/ssb/ssb-tribes2/node_modules/.pnpm/[email protected]/node_modules/async-append-only-log/index.js:251:5)
    at waitForLogLoaded (/home/me/prj/ssb/ssb-tribes2/node_modules/.pnpm/[email protected]/node_modules/async-append-only-log/index.js:616:12)
    at Object.log.get (/home/me/prj/ssb/ssb-tribes2/node_modules/.pnpm/[email protected]/node_modules/ssb-db2/log.js:105:5)
    at getMsgByOffset (/home/me/prj/ssb/ssb-tribes2/node_modules/.pnpm/[email protected]/node_modules/ssb-db2/core.js:269:9)

Powersource · 2023-05-04T18:50:55Z

was a weird mismatch between create and create tests. made this issue for some other time #107

package.json

socket-security · 2023-05-05T15:12:15Z

New dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary

Issue	Status
Install scripts	✅ 0 issues
Native code	✅ 0 issues
Bin script shell injection	✅ 0 issues
Unresolved require	✅ 0 issues
Invalid package.json	✅ 0 issues
HTTP dependency	✅ 0 issues
Git dependency	✅ 0 issues
Deprecated license	✅ 0 issues
Missing license	✅ 0 issues
Potential typo squat	✅ 0 issues
Known Malware	✅ 0 issues
Telemetry	✅ 0 issues
Protestware/Troll package	✅ 0 issues

📊 Modified Dependency Overview:

🚮 Removed packages: [email protected], [email protected]

lib/epochs.js

Powersource · 2023-05-08T13:55:22Z

updated keyring to fix a list() bug https://gitlab.com/ahau/lib/ssb-keyring/-/merge_requests/27

Powersource · 2023-05-09T10:15:11Z

hmm "publish many messages that might need pruning" is mysteriously freezing sometimes. i think it was happening before we merged the db2 optimization as well (test is gone because re-ran it)

Powersource · 2023-05-09T10:25:57Z

trying out using normal db2 config like in https://github.com/ssbc/ssb-tribes2/pull/108/files

index.js

Powersource · 2023-05-11T13:14:49Z

@mixmix made change and replied to comments

Powersource · 2023-05-11T17:35:09Z

oh no there's still flakes 😱

mixmix · 2023-05-12T04:00:31Z

@Powersource seems to be flaking on same test with 500 writes

suggestions:

try skipping the test test.skip
try setting the options for timeout manually on the test https://github.com/ljharb/tape#testname-opts-cb

test/add-member.test.js

Squashed commit of the following: commit 770f283 Author: mix irving <[email protected]> Date: Thu May 18 14:54:09 2023 +1200 blah commit 9e76b8e Author: mix irving <[email protected]> Date: Thu May 18 14:39:01 2023 +1200 rm ssb-caps, use randomBytes, add timeout for final test commit ffc89c4 Author: mix irving <[email protected]> Date: Thu May 18 14:16:09 2023 +1200 disable legacy-replication commit 61ad664 Author: mix irving <[email protected]> Date: Thu May 18 10:38:11 2023 +1200 add licenses to new files commit 38e8eeb Author: mix irving <[email protected]> Date: Thu May 18 10:36:35 2023 +1200 add legacyReplication commit 3dc4eb6 Author: mix irving <[email protected]> Date: Thu May 18 10:16:55 2023 +1200 fixups commit 5dacf0a Author: mix irving <[email protected]> Date: Thu May 18 09:54:41 2023 +1200 tests: log for when ebt fails to replicate commit 25d5c0f Author: Jacob Karlsson <[email protected]> Date: Fri May 12 12:12:46 2023 +0200 1.0.1 commit 8c896ad Author: Jacob Karlsson <[email protected]> Date: Fri May 12 12:12:34 2023 +0200 Include all lib files in module commit 0714473 Author: Jacob Karlsson <[email protected]> Date: Fri May 12 11:52:42 2023 +0200 1.0.0

lib/epochs.js

mixmix

Looks good.
I made what I think is an improved "replicate-all" that we can use everywhere.

Worked on this to get the tests passing :
#117

added-late_CI_FIXES

Powersource added 2 commits May 4, 2023 16:31

Split out getTipEpochs

4930b3e

One add-member per epoch tip

5172531

Powersource added 3 commits May 4, 2023 20:53

Update create test content

50c94c1

Update tests for new addMembers return

b26bb16

Add test for adding people to forked and old epochs

c702a05

Powersource mentioned this pull request May 5, 2023

Add oldSecrets field to add-member ssbc/private-group-spec#33

Merged

1 task

This comment was marked as duplicate.

Sign in to view

Send old secrets when adding a new member

962bc09

Powersource commented May 5, 2023

View reviewed changes

package.json Outdated Show resolved Hide resolved

Powersource commented May 5, 2023

View reviewed changes

lib/epochs.js Outdated Show resolved Hide resolved

Powersource mentioned this pull request May 8, 2023

Crash resistance for addMembers #110

Open

Powersource added 4 commits May 8, 2023 12:05

Consume old secrets we're given

65456c9

Check that sent oldSecrets is correct

b120eba

Update addMembers signature in readme

61ac83b

Fix create test

6bfd12b

Powersource marked this pull request as ready for review May 8, 2023 13:55

Remove log

72bed4b

Powersource requested a review from mixmix May 8, 2023 14:07

Powersource added 2 commits May 9, 2023 11:41

Update spec with oldSecrets

05fc30f

Merge branch 'master' of github.com:ssbc/ssb-tribes2 into added-late

d295dd7

Use normal db2 config for many-publish test

f2e36e6

Powersource mentioned this pull request May 9, 2023

Test adding someone back into the group #111

Merged

Powersource commented May 9, 2023

View reviewed changes

index.js Outdated Show resolved Hide resolved

Don't send old secrets on readditions

14d46c8

Powersource requested a review from mixmix May 11, 2023 13:14

Merge branch 'master' of github.com:ssbc/ssb-tribes2 into added-late

5b3ca84

Powersource added 2 commits May 16, 2023 15:21

Timeout publish many test

ebe3d7f

Add a lot of assertions to new test

2b21cb7

Powersource commented May 16, 2023

View reviewed changes

test/add-member.test.js Outdated Show resolved Hide resolved

Powersource and others added 11 commits May 16, 2023 16:20

Add timeouts

23ab8c1

Remove comments

2b6871e

More thorough replication in test

23c8708

More replication and timeouts

ef57736

Use normal db2 config

37f4523

Unparallelize replication

43f6eed

Careful replication

013b9f4

Log more on replication

a280bad

Replicate extra much

6f1b144

Replicate in the correct order

d457046

mixmix reviewed May 18, 2023

View reviewed changes

lib/epochs.js Show resolved Hide resolved

mixmix added 2 commits May 18, 2023 16:40

replace replicate-all

c76ead4

change unspecified names

4c42d82

mixmix approved these changes May 18, 2023

View reviewed changes

Powersource mentioned this pull request May 18, 2023

added-late_CI_FIXES #117

Merged

Powersource added 2 commits May 18, 2023 17:23

Merge pull request #117 from ssbc/added-late_CI_FIXES

5c33a1f

added-late_CI_FIXES

Add warning comment to replicate

cadcbe7

Powersource merged commit ae0d64a into master May 18, 2023

Powersource deleted the added-late branch May 18, 2023 15:48

Powersource mentioned this pull request Oct 22, 2023

Add new members to all tip epochs, and make sure that re-adding is allowed ssbc/ssb-group-exclusion-spec#36

Open

mixmix mentioned this pull request Feb 1, 2024

TRACKING: exclusion implementation #143

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

People added late to a group should get access to all epochs #106

People added late to a group should get access to all epochs #106

Powersource commented May 4, 2023 •

edited

Loading

Powersource commented May 4, 2023

Powersource commented May 4, 2023

This comment was marked as duplicate.

socket-security bot commented May 5, 2023 •

edited

Loading

Powersource commented May 8, 2023

Powersource commented May 9, 2023

Powersource commented May 9, 2023

Powersource commented May 11, 2023

Powersource commented May 11, 2023

mixmix commented May 12, 2023

mixmix left a comment

People added late to a group should get access to all epochs #106

People added late to a group should get access to all epochs #106

Conversation

Powersource commented May 4, 2023 • edited Loading

Powersource commented May 4, 2023

Powersource commented May 4, 2023

This comment was marked as duplicate.

socket-security bot commented May 5, 2023 • edited Loading

Powersource commented May 8, 2023

Powersource commented May 9, 2023

Powersource commented May 9, 2023

Powersource commented May 11, 2023

Powersource commented May 11, 2023

mixmix commented May 12, 2023

mixmix left a comment

Choose a reason for hiding this comment

Powersource commented May 4, 2023 •

edited

Loading

socket-security bot commented May 5, 2023 •

edited

Loading