OAuth GitHub support #320
Open
OAuth GitHub support #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since celery in dev mode is replaced by 'tianon/true', which exit fast,
the restart policy should be "no" in order to avoid entering in a restart loop.
The "no" needs to be escaped because it must be a "string", and the quotes (")
would be removed by 'awk' when processing the 'docker-compose.override.yml' template.
Signed-off-by: David Pordomingo <[email protected]>
Handle create, modify, move, rename and delete events. Signed-off-by: David Pordomingo <[email protected]>
It copies the modified 'docker-compose.override.yml' into '~/.sourced/compose-files/__active__/docker-compose.override.yml' Signed-off-by: David Pordomingo <[email protected]>
Signed-off-by: David Pordomingo <[email protected]>
Some files could be owned by 'root' inside of /home/superset (due to mounted volumes, caches...) All files inside of '/home/superset' should be owned by 'superset' Signed-off-by: David Pordomingo <[email protected]>
webpack-dev-server checks host headers and rejects the request
that comes from elsewhere.
When running source{d} from a dev env, it use to be accessed
from a regular domain, pointing to localhost, which would
trigger Webpack host check unless it runs with --disable-host-check
Signed-off-by: David Pordomingo <[email protected]>
Signed-off-by: David Pordomingo <[email protected]>
Google and GiHub OAuth providers can be used independently or simultaneously when authenticating in sourced-ui. The order of the providers to use will be defined by 'OAUTH_ENABLED_PROVIDERS' Signed-off-by: David Pordomingo <[email protected]>
|
@se7entyse7en I'm a newbie with Python (this is actually my first lines on Python), so I assume it is not real Python style, so feel free to suggest whatever should be addressed in that topic. |
This was referenced Nov 7, 2019
Signed-off-by: David Pordomingo <[email protected]>
dpordomingo
force-pushed
the
oauth-github
branch
from
12dffdf to
bcb9c59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
required by https://github.com/src-d/applications-backlog/issues/4
depends on #319 #316
This PR adds support for GitHub OAuth log-in, as it was done by #308, which added support for Google OAuth log-in. Now, both login methods can coexist.
This PR does not handle the GitHub user, which should be done in another PR.
See docs of usage on src-d/sourced-ce#265
You can enable GitHub and Google OAuth providers running:
which will enable this sign-in form:
