[WIP] Document how to enable OAuth #265
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Pordomingo <[email protected]>
dpordomingo
added
the
documentation
2 tasks
alexpdp7
reviewed
Nov 11, 2019
| - "Authorized domains": `${HOST}` | ||
| 1. Create a new "Credential" | ||
| - https://console.developers.google.com/apis/credentials | ||
| - create a new "Create OAuth client ID" for "Wab application" |
alexpdp7
reviewed
Nov 11, 2019
| - you can use `ngrok` if running source{d} locally: | ||
| ```shell | ||
| $ ngrok http 8088 | ||
| ``` |
There was a problem hiding this comment.
Have you verified this? I did not have any issues running on localhost with Google. Maybe this only happens with Github?
alexpdp7
reviewed
Nov 11, 2019
| - "Application name" | ||
| - "Restrictions": | ||
| - Authorized JavaScript origins: `${PROTOCOL}://${HOST}` | ||
| - Authorized redirect URIs: `${PROTOCOL}://${HOST}/oauth-authorized/google` |
There was a problem hiding this comment.
I think there was a way to restrict logins to the Google Apps domain (e.g. allow only @sourced.tech to log in). That's an interesting option to point out (not sure if Github has any kind of equivalent).
alexpdp7
approved these changes
Nov 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR documents the logging using GitHub and Google OAuth, as implemented by src-d/sourced-ui#320.
We could also consider if linking these docs from our main docs (also in GitBook).