Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nox setup & setup-remotes commands + other improvements #384

Merged
merged 4 commits into from
Sep 25, 2024

Conversation

CAM-Gerlach
Copy link
Member

Pull Request

Pull Request Checklist

  • Read and followed this repo's Contributing Guidelines
  • Based your PR on the latest version of the correct branch (master or 4.x)
  • Checked your writing carefully for correct English spelling, grammar, etc
  • Described your changes and the motivation for them below

Description of Changes

The new setup-remotes action not only sets up the origin and upstream remotes in both the recommended fetch and push configuration by connection method (HTTPS or SSH), but also detects and offers to fix issues with the existing config.

  • Implement final improvements and fixes to Nox infra
    • Add setup Nox action to set up upstream remote (and fetch), install hooks and clean build dir
    • Add setup action to Contributing Guide
    • Add docs alias for build commands (and also change _docs)
    • Also change run to error if no args passed
    • Check for and fix other issues

@CAM-Gerlach
Copy link
Member Author

CAM-Gerlach commented Sep 24, 2024

Linkcheck errors are due to the missing installers for Mac and Linux at present, and due to the Binder site being apparently completely down. Given there's not a strong urgency to merge this immediately, hopefully both are fixed tomorrow.

They are, I would presume, broken on our website too. It does beg the question of whether we should wait to publish the GitHub release until we know all the installers are built and ready to be uploaded, to avoid breaking everything. I thought we'd agreed to do something like that, but I guess maybe not? Or at least we could mark it as a pre-release until everything is ready, assuming that can be changed post facto?

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a single suggestion for you @CAM-Gerlach, the rest looks good to me.

noxfile.py Show resolved Hide resolved
noxfile.py Show resolved Hide resolved
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CAM-Gerlach!

@ccordoba12 ccordoba12 merged commit 32b9456 into spyder-ide:master Sep 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants