Remove Curlylint, add Black and fix ESLint #385
Conversation
|
Seems like there's a strange, hopefully temporary dependency conflict issue trying to install eslint (never seen that before), so hopefully that'll result itself in a day or two; there's no rush to merge this immediately. |
|
Welp, seems like the strange NPM dependency conflict that suddenly popped up has still not been resolved, so I'll dig in and investigate it myself. |
|
Welp, after several hours investigating, I reported this as eslint/eslint#18956 , and appears to be solved by eslint/eslint#18945 and was able to drill down to a workaround for now. Unfortunately, pinning the specific problematic dep didn't work for some reason, so I had to pin ESLint on a modestly older version for now until that's released. |
CAM-Gerlach
changed the title
There was a problem hiding this comment.
Looks good to me, but I think one thing is missing before merging: we should add commit 9e75d18 to .git-blame-ignore-revs so that it's ignored by git blame.
That's the recommended approach when applying Black to a repo and I think it's a good idea.
|
Okay, sure; I didn't add that before since the blackening only affects a couple scripts, and users need to either manually pass the path to that file every time, or (in recent-ish Git versions) manually configure Git to set and use this as the ignore file. However, after thinking about it a bit, I realized I can just add that to the things the I also noticed and fixed a small perf issue in |
Pull Request
Pull Request Checklist
Description of Changes
Followup from #383 and #384 , removes the unused, unmaintained and slow Jinja template linter Curlylint, adds the code formatter Black and applies the latter to blacken the repo's Python scripts (excluding the examples in the
/workshopssubdirectory). Additionally, adds a custom.black.tomlconfig file to avoid adding an unnecessary, inappropriate and potentially misleadingpyproject.tomlto this repo that's not any form of Python package.