Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QR Code "Scan to share" button that dispatches QR payload #34

Merged
merged 7 commits into from
Oct 9, 2024

Conversation

Joey-Silberman
Copy link
Contributor

@Joey-Silberman Joey-Silberman commented Oct 1, 2024

This PR adds a "Scan to share" button to the wallet home view (if there are any rawCredentials on the screen) which allows the user to scan a QR code whose payload will be dispatched with the dispatchQRcode function which is not yet implemented. The button will not appear if there are no credentials added yet.

I also bumped the CompileSDK version to match the newest version of Android Studio.

Note: This is the Android version of this PR: spruceid/mobile-sdk-ios-app#21

Copy link
Member

@Juliano1612 Juliano1612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The button and the redirection are working well, but there are some design issues

Copy link

@timothee-haudebourg timothee-haudebourg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it's almost ready! I just have the same comment as for the Android PR: this PR should have no mention of OID4VP. The task is to add a QR-code button handing over the QR-code payload to a generic dispatch function.

It is correct that in the near future we will extend the dispatch function to trigger the OID4VP flow, but this PR should be completely agnostic about that.

@timothee-haudebourg
Copy link

Question: what happens currently when the QR-code is scanned?

Copy link
Member

@Juliano1612 Juliano1612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The button is working and is always visible! Just a few code suggestions to finish

@Juliano1612
Copy link
Member

Question: what happens currently when the QR-code is scanned?

It only redirects to a new component that will handle the OID4VP integration, but the OID4VP flow will be integrated in another PR

@Joey-Silberman Joey-Silberman changed the title Add QR Code "scan to share" button that redirects to OID4VP flow Add QR Code "Scan to share" button that dispatches QR payload Oct 4, 2024
@Ryanmtate Ryanmtate mentioned this pull request Oct 5, 2024
@Ryanmtate
Copy link
Contributor

Question: what happens currently when the QR-code is scanned?

It only redirects to a new component that will handle the OID4VP integration, but the OID4VP flow will be integrated in another PR

#37 contains a handler to navigate to an OID4VP view.

@timothee-haudebourg timothee-haudebourg self-requested a review October 9, 2024 16:40
@Joey-Silberman Joey-Silberman merged commit 8b2a6be into main Oct 9, 2024
2 checks passed
@Joey-Silberman Joey-Silberman deleted the skit-580-holder-qr-code-reader-button branch October 9, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants