-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add QR Code "Scan to share" button that dispatches QR payload #34
Conversation
example/src/main/java/com/spruceid/mobilesdkexample/wallet/WalletHomeView.kt
Outdated
Show resolved
Hide resolved
example/src/main/java/com/spruceid/mobilesdkexample/wallet/WalletHomeView.kt
Outdated
Show resolved
Hide resolved
…are button is pressed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The button and the redirection are working well, but there are some design issues
example/src/main/java/com/spruceid/mobilesdkexample/wallet/WalletHomeView.kt
Outdated
Show resolved
Hide resolved
example/src/main/java/com/spruceid/mobilesdkexample/wallet/WalletHomeView.kt
Outdated
Show resolved
Hide resolved
example/src/main/java/com/spruceid/mobilesdkexample/wallet/WalletHomeView.kt
Outdated
Show resolved
Hide resolved
example/src/main/java/com/spruceid/mobilesdkexample/wallet/WalletHomeView.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like it's almost ready! I just have the same comment as for the Android PR: this PR should have no mention of OID4VP. The task is to add a QR-code button handing over the QR-code payload to a generic dispatch function.
It is correct that in the near future we will extend the dispatch function to trigger the OID4VP flow, but this PR should be completely agnostic about that.
Question: what happens currently when the QR-code is scanned? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! The button is working and is always visible! Just a few code suggestions to finish
example/src/main/java/com/spruceid/mobilesdkexample/wallet/WalletHomeView.kt
Outdated
Show resolved
Hide resolved
example/src/main/java/com/spruceid/mobilesdkexample/wallet/WalletHomeView.kt
Outdated
Show resolved
Hide resolved
example/src/main/java/com/spruceid/mobilesdkexample/wallet/WalletHomeView.kt
Show resolved
Hide resolved
It only redirects to a new component that will handle the OID4VP integration, but the OID4VP flow will be integrated in another PR |
#37 contains a handler to navigate to an OID4VP view. |
This PR adds a "Scan to share" button to the wallet home view (if there are any
rawCredentials
on the screen) which allows the user to scan a QR code whose payload will be dispatched with thedispatchQRcode
function which is not yet implemented. The button will not appear if there are no credentials added yet.I also bumped the CompileSDK version to match the newest version of Android Studio.
Note: This is the Android version of this PR: spruceid/mobile-sdk-ios-app#21