OID4VP #37
Merged
OID4VP #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ryanmtate
requested review from
rschulman,
w4ll3,
Juliano1612 and
Joey-Silberman
Ryanmtate
commented
Oct 4, 2024
Ryanmtate
commented
Oct 5, 2024
example/src/main/java/com/spruceid/mobilesdkexample/wallet/AchievementCredentialItem.kt
Outdated
Show resolved
Hide resolved
Ryanmtate
force-pushed
the
skit-459-oid4vp
branch
from
de24ae8 to
e29296a
Compare
Ryanmtate
commented
Oct 7, 2024
MobileSdk/src/main/java/com/spruceid/mobile/sdk/oid4vp/CredentialCallback.kt
Outdated
Show resolved
Hide resolved
Ryanmtate
commented
Oct 7, 2024
MobileSdk/src/main/java/com/spruceid/mobile/sdk/oid4vp/CredentialCallback.kt
Outdated
Show resolved
Hide resolved
Ryanmtate
changed the base branch from
skit-580-holder-qr-code-reader-button
to
main
Ryanmtate
force-pushed
the
skit-459-oid4vp
branch
3 times, most recently
from
1e47f6a to
fc56ec0
Compare
Ryanmtate
commented
Oct 9, 2024
example/src/main/java/com/spruceid/mobilesdkexample/wallet/HandleOID4VPView.kt
Outdated
Show resolved
Hide resolved
Ryanmtate
force-pushed
the
skit-459-oid4vp
branch
2 times, most recently
from
1593dd3 to
fb20924
Compare
Signed-off-by: Ryan Tate <[email protected]>
Ryanmtate
force-pushed
the
skit-459-oid4vp
branch
from
fb20924 to
a7aa2f5
Compare
Signed-off-by: Ryan Tate <[email protected]>
example/src/main/java/com/spruceid/mobilesdkexample/wallet/DispatchQRView.kt
Show resolved
Hide resolved
example/src/main/java/com/spruceid/mobilesdkexample/wallet/DispatchQRView.kt
Show resolved
Hide resolved
example/src/main/java/com/spruceid/mobilesdkexample/wallet/DispatchQRView.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Ryan Tate <[email protected]>
Signed-off-by: Ryan Tate <[email protected]>
This implements the UI for the OID4VP flow and adds an error page
This refactors the credential display components to make them compatible with generic credential types and finishes the OID4VP and OID4VCI integrations.
Juliano1612
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this branch is based on #34, change branch to main and rebase after merge.