Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use newer scipy gaussian window fn #122

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Use newer scipy gaussian window fn #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85df25b
Use newer scipy gaussian window fn
Apr 16, 2024
04030e9
Fix ML Libs version pins
Apr 16, 2024
0edd6ce
tf pin
Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion basic_pitch/note_creation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ def get_pitch_bends(
note events with pitch bends
"""
window_length = n_bins_tolerance * 2 + 1
freq_gaussian = scipy.signal.gaussian(window_length, std=5)
freq_gaussian = scipy.signal.windows.gaussian(window_length, std=5)
note_events_with_pitch_bends = []
for start_idx, end_idx, pitch_midi, amplitude in note_events:
freq_idx = int(np.round(midi_pitch_to_contour_bin(pitch_midi)))
Expand Down
12 changes: 6 additions & 6 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[project]
name = "basic-pitch"
version = "0.3.0"
version = "0.3.1"
description = "Basic Pitch, a lightweight yet powerful audio-to-MIDI converter with pitch bend detection."
keywords = []
classifiers = [
Expand All @@ -17,7 +17,7 @@ classifiers = [
"Programming Language :: Python :: Implementation :: CPython",
]
dependencies = [
"coremltools; platform_system == 'Darwin' and python_version < '3.11'",
"coremltools; platform_system == 'Darwin'",
"librosa>=0.8.0",
"mir_eval>=0.6",
"numpy>=1.18",
Expand All @@ -26,8 +26,8 @@ dependencies = [
"resampy>=0.2.2,<0.4.3",
"scikit-learn",
"scipy>=1.4.1",
"tensorflow>=2.4.1,<2.16; platform_system != 'Darwin' and python_version >= '3.11'",
"tensorflow-macos>=2.4.1; platform_system == 'Darwin' and python_version >= '3.11'",
"tensorflow>=2.4.1,<2.15.1; platform_system != 'Darwin' and python_version >= '3.11'",
drubinstein marked this conversation as resolved.
Show resolved Hide resolved
"tensorflow-macos>=2.4.1,<2.15.1; platform_system == 'Darwin'",
"tflite-runtime; platform_system == 'Linux' and python_version < '3.11'",
"typing_extensions",
]
Expand Down Expand Up @@ -56,8 +56,8 @@ test = [
"pytest-mock",
]
tf = [
"tensorflow>=2.4.1,<2.16; platform_system != 'Darwin'",
"tensorflow-macos>=2.4.1,<2.16; platform_system == 'Darwin' and python_version > '3.7'",
"tensorflow>=2.4.1,<2.15.1; platform_system != 'Darwin'",
"tensorflow-macos>=2.4.1,<2.15.1; platform_system == 'Darwin' and python_version > '3.7'",
]
coreml = ["coremltools"]
onnx = ["onnxruntime"]
Expand Down
Loading