Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use newer scipy gaussian window fn #122

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Use newer scipy gaussian window fn #122

merged 3 commits into from
Apr 19, 2024

Conversation

drubinstein
Copy link
Contributor

Handles #120. Scipy added this function in 1.1.0 and basic-pitch requires scipy>1.4 so we should be safe.

@drubinstein drubinstein requested a review from zwycl April 17, 2024 17:13
zwycl
zwycl reviewed Apr 19, 2024
View reviewed changes
Copy link
Contributor

@zwycl zwycl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm the two functions are the same. Just one comment.

pyproject.toml Show resolved Hide resolved
@drubinstein drubinstein requested a review from zwycl April 19, 2024 19:40
@drubinstein drubinstein merged commit f91109d into main Apr 19, 2024
20 checks passed
@drubinstein drubinstein deleted the update-gaussian branch April 19, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zwycl zwycl zwycl approved these changes

@dohertyguirand dohertyguirand Awaiting requested review from dohertyguirand

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drubinstein @zwycl