Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for 0.7.2 #685

Merged
merged 27 commits into from
Jan 22, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
d2c77c0
Bump to 0.7.2-dev
evan2645 Jan 22, 2019
05aa15b
Add go-modules to build system
marcosy Dec 21, 2018
77f79a0
Removing dep-related commands and files
marcosy Dec 24, 2018
b408737
incorrect syntax for aws_iid resolver example in docs
dgervais Dec 26, 2018
bbcd670
deprecate use of github.com/satori/go.uuid for github.com/gofrs/uuid
dgervais Dec 22, 2018
acf0492
Makefile refactor, adding help target
marcosy Dec 26, 2018
395fe58
Updating documentation
marcosy Dec 26, 2018
26702ea
Updating gofrs to use modules
marcosy Dec 27, 2018
afbfea1
Removing missing dep references
marcosy Dec 27, 2018
e6e639b
Dont allow agents to specify X509-SVID Subject
evan2645 Dec 6, 2018
955c7d4
Adding new module for tools/utils
marcosy Jan 2, 2019
cd962b6
registration API auth via SPIFFE
azdagron Dec 14, 2018
d01f0fd
Move utils to tools folder (recommended name)
marcosy Jan 3, 2019
8ba3a12
Run 'go mod tidy' in tools module
marcosy Jan 3, 2019
b69a8c6
refactor to require handler to handle authorization
azdagron Jan 4, 2019
c496148
additional error info when no auth implemented
azdagron Jan 8, 2019
5f0d8b4
Selecting node resolver based on attestation type
marcosy Dec 10, 2018
6bf97a9
Improve test cases based on PR comments
marcosy Dec 19, 2018
c84765c
Fix debug message formatting in node resolver
Jan 7, 2019
1d8c5b1
proto/agent/keymanager: Add StorePrivateKey to plugin API
Jan 11, 2019
8f0ea4e
pkg/agent: Update KeyManager implementations and svid rotator logic
Jan 11, 2019
bee8f6f
agent/svid: Refactor key storage, add atomic disk writes
Jan 11, 2019
ed378c6
Fixup protobuf docs
Jan 12, 2019
9ad67c8
Fix agent keymanager protobuf generation
Jan 12, 2019
c03b9c5
agent/nodeattestor/gcp: Use FQDN to find metadata server
Jan 14, 2019
1adef15
agent/common/cgroups: Move cgroup logic from k8s attestor to common
Jan 15, 2019
3be05dc
Fix node api handler test following conflict resolution
evan2645 Jan 22, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ cache:

script:
- ./build.sh setup
- ./build.sh vendor
- ./build.sh utils
- ./build.sh protobuf_verify
- ./build.sh test
Expand Down Expand Up @@ -42,8 +41,8 @@ deploy:
on:
tags: true
condition: $GITHUB_TOKEN != ""

notifications:
slack:
secure: auV9VWkA50+tf4cKUUkMH/KqggKSJCBV9ruLSF1LVgqQYnK34rp/PPzx4gTiQYA07ltnu8Hi13XMoN5+OFsRfzVRCKP1tlGuTvVhpsoyMGiNxBY1Yw2OhZXRoSjCwJkuBsAkkaxAgsC58IEnxhKq+M83dDYx+WiybO+aQnQ6ExbGE4oUBhhBkYKrHy4Kt9/3yWLqicV/VXFtvwbXG5OG1zNNOYCUEud4Y8j6pcb0kyVqlHFjAjasLPsln0QSaTxOThLZCxMZD2zpbI1xxO5tBusqDe1QOMSgsyAbDaNk7wCb2kU+0hRKcfiuWShrswhECSJsYUImLq4c77WbdhrjRgscgY2779T/jaJHbG3Lx7GlDWYLSgFcM8VfZK+K5XPcm35F2qGPiEjtYEEAPS2qQM9PZyvTEVPxjNEc2PE3bINTjibcKbfATNa1ULQvJ6ixtSL9Ao8828iUfaR0mK4eaWnJckov5OaGvah+v6vh49JqZTEN3Or8XTUw0ra14euS6jR30XB2Y3S8/0NuvHY+ytJe36yQn9FdFM3asNpBuNP7F9v00WJr3+Lhg7KHMd0m19ulwtmXiWJYU25AVMk/oXp+aq+678AvhYkYZGaUzC3timsuTlAjH9DA9yxBW+8KE9y46Jq8vXHXhKTfdKDVVUyOFxKKGAjCA5QbeKx+5QU=

21 changes: 7 additions & 14 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@ from the SPIFFE project.

For basic development you will need:

* **Go** (https://golang.org/dl/)
* **Dep**, for managing third-party dependancies (https://github.com/golang/dep)
* **Go 1.11** or higher (https://golang.org/dl/)

For development that requires changes to the gRPC interfaces you will need:

Expand All @@ -22,25 +21,23 @@ For development that requires changes to the gRPC interfaces you will need:

# Building

It is assumed that this repository lives in $GOPATH/src/github.com/spiffe/spire on your local disk,
and that your GOPATH only contains one element.
Since go modules are used, this repository can live in any folder on your local disk (it is not required to be in GOPATH).

Because of the use of dep and the unusual layout of this repository a Makefile is provide for
common actions.
A Makefile is provided for common actions.

* `dep ensure` - installs all the dependencies listed in Gopkg.toml
* `make all` - installs 3rd-party dependencies, build all binaries, and run all tests
* `make` - builds all binaries
* `make cmd/spire-agent` - builds one binary
* `make test` - runs all tests

**Other Makefile targets**

* `vendor` - installs 3rd-party dependencies using dep
* `vendor` - Make vendored copy of dependencies using go mod
* `race-test` - run `go test -race`
* `clean` - cleans `vendor` directory, dep cache
* `clean` - cleans `vendor` directory
* `distclean` - removes caches in addition to `make clean`
* `utils` - installs gRPC related development utilities
* `help` - shows makefile targets and description

## Development in Docker

Expand All @@ -60,10 +57,7 @@ $ make container
$ make cmd
```

Because the docker container shares $GOPATH you will not have to re-install the go dependencies
every time you run the container. NOTE: any binaries installed from within the container will be
located in $GOPATH/bin/linux_amd64 to avoid conflicts with the host OS (Packages are automatically
versioned by golang into `$GOPATH/pkg/<os>_<arch>`)
Because the docker container shares `$GOPATH/pkg/mod` you will not have to re-install the go dependencies every time you run the container.

## CI

Expand All @@ -74,7 +68,6 @@ checks. It is also used to bootstrap the Go environment in the Docker container.
* `protobuf` - regenerate the gRPC pb.go and README.md files
* `protobuf_verify` - check that the checked-in generated code is up-to-date
* `distclean` - calls `make distclean` and removes the directory `.build-<os>-<arch>`
* `vendor` - calls `make vendor` and checks that the `Gopkg.lock` file is up-to-date
* `artifact` - generate a `.tgz` containing all of the SPIFFE binaries
* `test` - when called from within a Travis-CI build, runs coverage tests in addition to the
regular tests
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ ENV GOROOT=/root/build
ENV GOBIN=$GOPATH/bin/linux_amd64
ENV PATH=$GOROOT/bin:$GOBIN:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
RUN mkdir /root/go
WORKDIR /root/go/src/github.com/spiffe/spire
WORKDIR /root/spire
Loading