-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for 0.7.2 #685
Merged
Merged
Prepare for 0.7.2 #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evan Gilman <[email protected]>
Signed-off-by: Marcos G. Yedro <[email protected]>
Signed-off-by: Marcos G. Yedro <[email protected]>
updated example from: arn:aws:iam::123456789012:instance-profile/Blog to: iamrole:arn:aws:iam::123456789012:instance-profile/Blog Signed-off-by: David Gervais <[email protected]>
Gopkg.toml version of [email protected] did not include non-random uuid fix: satori/go.uuid#73 also, deprecation notice for satori/go.uuid posted via issue: satori/go.uuid#84 community recommended replacement is available at github.com/gofrs/uuid * updated Gopkg.toml to use github.com/gofrs/uuid @ 3.1.2 * rebuilt Gopkg.lock * incorporate symmantics of uuid.NewV4() can return error Signed-off-by: David Gervais <[email protected]>
Signed-off-by: Marcos G. Yedro <[email protected]>
Signed-off-by: Marcos G. Yedro <[email protected]>
Signed-off-by: Marcos G. Yedro <[email protected]>
Signed-off-by: Marcos G. Yedro <[email protected]>
Currently, SPIRE server signs certificates using the subject specified in the CSR. Since SPIRE has no way of actually validating this information, it should not be included. The agent generates CSRs with a hardcoded Subject. As a quick fix, this commit uses the same hardcoded Subject except it is set on the server side directly. Signed-off-by: Evan Gilman <[email protected]>
Signed-off-by: Marcos G. Yedro <[email protected]>
- added "admin" flag to registration entries - updated CLI to support "admin" flag - refactored registration handler tests to unify code and remove mocking Signed-off-by: Andrew Harding <[email protected]>
Signed-off-by: Marcos G. Yedro <[email protected]>
Signed-off-by: Marcos G. Yedro <[email protected]>
Signed-off-by: Andrew Harding <[email protected]>
Signed-off-by: Andrew Harding <[email protected]>
Signed-off-by: Marcos G. Yedro <[email protected]>
Signed-off-by: Marcos G. Yedro <[email protected]>
Signed-off-by: Scott Emmons <[email protected]>
Signed-off-by: R. Tyler Julian <[email protected]>
Signed-off-by: R. Tyler Julian <[email protected]>
Signed-off-by: R. Tyler Julian <[email protected]>
Signed-off-by: R. Tyler Julian <[email protected]>
Signed-off-by: R. Tyler Julian <[email protected]>
In GCP node attestation, we request the instance identity token using the `metadata` DNS record. This uses `/etc/resolv.conf` to expand into `metadata.google.internal`; however, this means that node attestation has a dependency on GCP's default resolution, which makes it difficult for consumers with custom DNS resolvers. ``` $ cat /etc/resolv.conf domain foo.internal search foo.internal. google.internal. nameserver 169.254.169.254 ``` This change removes the dependency on `/etc/resolv.conf` by querying the metadata server using its FQDN `metadata.google.internal`. Signed-off-by: R. Tyler Julian <[email protected]>
This change moves cgroup-related logic in the k8s plugin to a shared agentutil package, since workload attestation using other docker-based orchestration platforms needs to do similar cgroup lookups. Signed-off-by: R. Tyler Julian <[email protected]>
evan2645
requested review from
ajessup,
amartinezfayo,
azdagron and
drrt
as code owners
January 22, 2019 21:57
evan2645
requested review from
MarcosDY,
martincapello and
walmav
as code owners
January 22, 2019 21:57
azdagron
previously approved these changes
Jan 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I think we're ok on compatability.
Looks like I flubbed some of the conflict resolution when cherry-picking from master. This small commit corrects the error and pulls the node api handler tests up to equal the contents in master. Signed-off-by: Evan Gilman <[email protected]>
azdagron
approved these changes
Jan 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A golang release is expected to drop tomorrow to address a yet-to-be-announced vulnerability. This PR pulls up the 0.7 branch in anticipation of a SPIRE release with the updated version.
The commits in this PR have been cherry-picked from master and thus have already undergone CR. Please review this PR from an upgrade compatibility standpoint.
The changelog-worthy updates: