deprecate use of github.com/satori/go.uuid for github.com/gofrs/uuid #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgervais
requested review from
amartinezfayo,
azdagron,
evan2645,
MarcosDY,
martincapello and
walmav
as code owners
Gopkg.toml version of [email protected] did not include non-random uuid fix: satori/go.uuid#73 also, deprecation notice for satori/go.uuid posted via issue: satori/go.uuid#84 community recommended replacement is available at github.com/gofrs/uuid * updated Gopkg.toml to use github.com/gofrs/uuid @ 3.1.2 * rebuilt Gopkg.lock * incorporate symmantics of uuid.NewV4() can return error Signed-off-by: David Gervais <[email protected]>
dgervais
force-pushed
the
new_uuid_feature
branch
from
fc63a05
to
7be8c67
Compare
evan2645
approved these changes
Dec 26, 2018
| @@ -33,10 +33,14 @@ type subscribers struct { | |||
| } | |||
|
|
|||
| func NewSubscriber(selectors Selectors) (*subscriber, error) { | |||
| u, err := uuid.NewV4() | |||
| if err != nil { | |||
| return nil, err | |||
There was a problem hiding this comment.
Heh... for your amusement, I present you with 7e39858#diff-bc189db1d67c0b2efdefb255c26b6b3d
There was a problem hiding this comment.
heh ... who says acyclic graphs never have loops ;-)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gopkg.toml version of [email protected] did not include non-random uuid fix:
satori/go.uuid#73
also, deprecation notice for satori/go.uuid posted via issue:
satori/go.uuid#84
community recommended replacement is available at github.com/gofrs/uuid
Signed-off-by: David Gervais [email protected]