Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

couple of fixes for rendering #296

Closed
wants to merge 1 commit into from
Closed

couple of fixes for rendering #296

wants to merge 1 commit into from

Conversation

zvr
Copy link
Member

@zvr zvr commented Apr 29, 2020

related to #285

  • missed another list in 1.7.5 (point 1 in list)
  • missed a closing parenthesis in 5.3.6 (point 4 in list)

@zvr zvr added this to the 2.2 milestone Apr 29, 2020
@zvr zvr requested a review from tsteenbe April 29, 2020 08:21
@zvr zvr mentioned this pull request Apr 29, 2020
Closed
@swinslow swinslow mentioned this pull request Apr 29, 2020
Merged
@swinslow
Copy link
Member

Hi @zvr, the PR I submitted at #299 included the line break for 1.7.5, along with a few other nits. I've also now added the 5.3.6 fix you caught. So I think #299 will handle both of these. Thanks!

@kestewart
Copy link
Contributor

Closing this, as I believe they've been handled by Steve's just now. Please reopen if I'm mis reading something.

@kestewart kestewart closed this Apr 29, 2020
@zvr zvr deleted the rendering-typos branch May 9, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteenbe tsteenbe Awaiting requested review from tsteenbe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@zvr @swinslow @kestewart