Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering issues #285

Closed
zvr opened this issue Apr 27, 2020 · 9 comments
Closed

Rendering issues #285

zvr opened this issue Apr 27, 2020 · 9 comments
Assignees
Milestone

Comments

@zvr
Copy link
Member

zvr commented Apr 27, 2020

I've gone through all pages of the spec and marked some issues:

  1. list and links in 1.7.6 not rendered
  2. example tag-value in 4.16.5 is in red
  3. example RDF in 5.3.6 is in red
  4. classes in 5.3.6 are not in code (cf. 5.4.6)
  5. reference to "Appendix IV" in 5.5.1 is not a link
  6. should the list of all relationship types be sorted by name?
  7. example RDF in 7.1.6 is incorrectly indented
  8. property and class in 8.2.6 not in code
  9. sections 9.2 and 9.3 do not appear in table of contents
  10. no sections of Appendix II appear in table of contents
  11. numbering in CC-BY-3.0 license text in appendix restarts from 1 in different places
@zvr zvr added this to the 2.2 milestone Apr 27, 2020
@kestewart
Copy link
Contributor

@zvr, can you re-check the renderings of the lists, when you get on line? I applied William's fix this evening, so hopefully the list issues are sorted.

kestewart added a commit that referenced this issue Apr 28, 2020
Should fix #9 in issue #285
kestewart added a commit that referenced this issue Apr 28, 2020
This makes handling consistent with 5.4.6 - see #285 - addresses issue number 4.
@kestewart
Copy link
Contributor

@tsteenbe - can you look into why some parts are rendering in "red", no clue from looking at the source why this is so.

kestewart added a commit that referenced this issue Apr 28, 2020
This makes handling consistent with 5.4.6 - see #285 - addresses issue number 4.
kestewart added a commit that referenced this issue Apr 28, 2020
Should fix #9 in issue #285
@tsteenbe
Copy link
Member

Of @zvr list only point 6 and 11 are still to-do the rest has been addressed in #294

@tsteenbe
Copy link
Member

Fixed 11 in #295.

@kestewart
Copy link
Contributor

@zvr - can you check we've got them all handled, and then close this?

@tsteenbe
Copy link
Member

@kestewart as said above I still need to implement 6 which I will do later today, for 11 the PR is still open but all the other points should now be fixed, see https://spdx.github.io/spdx-spec/v2-draft/

zvr added a commit to zvr/spdx-spec that referenced this issue Apr 29, 2020
@zvr
Copy link
Member Author

zvr commented Apr 29, 2020

Can confirm that everything is OK besides 6 and 11 (well, with a couple of typos I submitted in #296)

@kestewart
Copy link
Contributor

Thanks @zvr for confirming! PR #299 from Steve has been applied to address the issues you caught in #296 and a few others.

@tsteenbe - standing by for PR, and then we can close this issue.

@kestewart
Copy link
Contributor

@tsteenbe - please do not implement #6 (should the list of all relationship types be sorted by name?
https://spdx.github.io/spdx-spec/v2-draft/7-relationships-between-SPDX-elements/#71-relationship). I was looking at it and I think its going to end up being more confusing. Right now related things are roughly grouped together. @zvr - Lets revisit this in 3.0.

@zvr - #11 is merged now. I'm going to mark this as closed. Please reopen if you disagree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants