Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack list content #695

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Stack list content #695

merged 3 commits into from
Dec 18, 2024

Conversation

jakubabrzy
Copy link
Contributor

Description of the change

Checklist

Please make sure that the proposed change checks all the boxes below before requesting a review:

  • I have reviewed the guidelines for contributing to this repository.
  • The preview looks fine.
  • The tests pass.
  • The commit history is clean and meaningful.
  • The pull request is opened against the main branch.
  • The pull request is no longer marked as a draft.
  • You agree to license your contribution under the MIT license to Spacelift (not required for Spacelift employees).
  • You have updated the navigation files correctly:
    • No new pages have been added, or;
    • Only nav.yaml has been updated because the changes only apply to SaaS, or;
    • Only nav.self-hosted.yaml has been updated because the changes only apply to Self-Hosted, or;
    • Both nav.yaml and nav.self-hosted.yaml have been updated.

If the proposed change is ready to be merged, please request a review from @spacelift-io/solutions-engineering. Someone will review and merge the pull request.

Spacelift employees should request reviews from the relevant engineers and are allowed to merge pull requests after they got at least one approval.

Thank you for your contribution! 🙇

docs/concepts/stack/organizing-stacks.md Outdated Show resolved Hide resolved
docs/concepts/stack/organizing-stacks.md Outdated Show resolved Hide resolved
docs/concepts/stack/organizing-stacks.md Outdated Show resolved Hide resolved
docs/concepts/stack/organizing-stacks.md Outdated Show resolved Hide resolved
docs/concepts/stack/organizing-stacks.md Outdated Show resolved Hide resolved
docs/concepts/stack/organizing-stacks.md Outdated Show resolved Hide resolved
flavius-dinu
flavius-dinu previously approved these changes Dec 18, 2024
Copy link
Contributor

@flavius-dinu flavius-dinu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamconnelly adamconnelly temporarily deployed to stack-list-content - spacelift-user-documentation PR #695 December 18, 2024 09:44 — with Render Destroyed
@michalg9 michalg9 requested a review from a team December 18, 2024 10:02
@jakubabrzy jakubabrzy merged commit 3e17a56 into main Dec 18, 2024
1 check passed
@jakubabrzy jakubabrzy deleted the stack-list-content branch December 18, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants