Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXP: try pinning maturin to <1.3.0 to fix dev build CI #2799

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Oct 3, 2023

As of 17 hours ago (so, like, midnight PDT on Oct 2?), "Dev env instructions" build is failing.

The error might belong to maturin - here is the message:

Processing ./.tox/.tmp/package/1/sourmash-4.8.5.dev0.tar.gz
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Getting requirements to build wheel: started
  Getting requirements to build wheel: finished with status 'done'
  Preparing metadata (pyproject.toml): started
  Preparing metadata (pyproject.toml): finished with status 'error'
  error: subprocess-exited-with-error
  
  × Preparing metadata (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [12 lines of output]
      error: current package believes it's in a workspace when it's not:
      current:   /tmp/pip-req-build-x9u8ulfq/src/core/Cargo.toml
      workspace: /tmp/pip-req-build-x9u8ulfq/Cargo.toml
      
      this may be fixable by adding `src/core` to the `workspace.members` array of the manifest located at: /tmp/pip-req-build-x9u8ulfq/Cargo.toml
      Alternatively, to keep it out of the workspace, add the package to the `workspace.exclude` array, or add an empty `[workspace]` table to the package's manifest.
      💥 maturin failed
        Caused by: Cargo metadata failed. Does your crate compile with `cargo build`?
        Caused by: `cargo metadata` exited with an error:
      Error running maturin: Command '['maturin', 'pep517', 'write-dist-info', '--metadata-directory', '/tmp/pip-modern-metadata-v0x443be', '--interpreter', '/home/runner/work/sourmash/sourmash/.tox/py39/bin/python']' returned non-zero exit status 1.
      Checking for Rust toolchain....
      Running `maturin pep517 write-dist-info --metadata-directory /tmp/pip-modern-metadata-v0x443be --interpreter /home/runner/work/sourmash/sourmash/.tox/py39/bin/python`
      [end of output]

Looking at the maturin releases, v1.3.0 was released yesterday, so maybe that's the problem? Trying out this PR as a temporary fix.

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #2799 (a1e943e) into latest (ba1fd3e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           latest    #2799   +/-   ##
=======================================
  Coverage   85.94%   85.94%           
=======================================
  Files         130      130           
  Lines       14808    14808           
  Branches     2621     2621           
=======================================
  Hits        12727    12727           
  Misses       1780     1780           
  Partials      301      301           
Flag Coverage Δ
hypothesis-py 25.82% <ø> (ø)
python 92.85% <ø> (ø)
rust 49.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ctb
Copy link
Contributor Author

ctb commented Oct 3, 2023

@sourmash-bio/devs ready for review - I'll merge this as a build fix next time I look at the PRs (this evening maybe?) unless there are objections.

@luizirber luizirber self-requested a review October 3, 2023 14:44
Copy link
Member

@luizirber luizirber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to fix the issue for now, but it is likely that maturin has better workspace support and we can change

manifest-path = "src/core/Cargo.toml"
to point to Cargo.toml instead of src/core/Cargo.toml now

@ctb ctb merged commit 4016041 into latest Oct 3, 2023
35 checks passed
@ctb ctb deleted the pin_maturin_123 branch October 3, 2023 14:51
@ctb ctb mentioned this pull request Oct 3, 2023
bluegenes added a commit that referenced this pull request Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants