Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: chrono version pin #2798

Merged
merged 2 commits into from
Oct 9, 2023
Merged

MRG: chrono version pin #2798

merged 2 commits into from
Oct 9, 2023

Conversation

bluegenes
Copy link
Contributor

@bluegenes bluegenes commented Oct 2, 2023

To install sourmash from mastiff branch in pyo3-branchwater, I need to bump chrono back to 0.4.28 (from 0.4.31) to avoid incompatibilities with piz.

but maybe you have a better solution, @luizirber?

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #2798 (b561e7c) into lirber/mastiff (3a13ab2) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           lirber/mastiff    #2798   +/-   ##
===============================================
  Coverage           85.70%   85.70%           
===============================================
  Files                 135      135           
  Lines               15367    15367           
  Branches             2621     2621           
===============================================
  Hits                13170    13170           
  Misses               1896     1896           
  Partials              301      301           
Flag Coverage Δ
hypothesis-py 25.82% <ø> (ø)
python 92.85% <ø> (ø)
rust 55.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ctb
Copy link
Contributor

ctb commented Oct 3, 2023

I think you'll need to merge #2799 into this, too, to get the tests to pass.

@bluegenes
Copy link
Contributor Author

I think you'll need to merge #2799 into this, too, to get the tests to pass.

done, thanks!

@luizirber luizirber merged commit 8464094 into lirber/mastiff Oct 9, 2023
35 checks passed
@luizirber luizirber deleted the mastiff-chrono-patch branch October 9, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants