[MRG] add sourmash sig check for comparing picklists and databases
#1907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctb
changed the title
sourmash sig check for comparing/diffing picklists and manifestssourmash sig check for comparing picklists and manifests
ctb
changed the title
sourmash sig check for comparing picklists and manifestssourmash sig check for comparing picklists and databases
12 tasks
Codecov Report
@@ Coverage Diff @@
## latest #1907 +/- ##
==========================================
+ Coverage 82.82% 82.96% +0.13%
==========================================
Files 122 123 +1
Lines 13254 13365 +111
Branches 1789 1808 +19
==========================================
+ Hits 10978 11088 +110
Misses 2013 2013
- Partials 263 264 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ctb
changed the title
sourmash sig check for comparing picklists and databasessourmash sig check for comparing picklists and databases
|
ready for review & merge @sourmash-bio/devs |
bluegenes
approved these changes
Mar 30, 2022
|
🎉 |
This was referenced Mar 30, 2022
This was referenced May 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
sourmash sig checkcommand to compare picklists and databases.This PR builds on the manifest-as-database work from #1891.
sig checkmakes it possible to output manifests for signatures that match a picklist, as well as extracting unmatched values from picklists.sig checkis extremely, extraordinarily useful when building large databases for which you have all of the signatures available ...somewhere! See #1671 for background and details.Addresses #1671.
Closes #1652.
sig checksig checksig check --fail-if-missingto error exit when missing elementssig checkshould require manifests on input databases-m?) on sig check for--save-manifest