-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] implement sourmash sketch fromfile
#1885
Conversation
Codecov Report
@@ Coverage Diff @@
## latest #1885 +/- ##
==========================================
+ Coverage 82.96% 83.22% +0.26%
==========================================
Files 123 124 +1
Lines 13367 13601 +234
Branches 1808 1861 +53
==========================================
+ Hits 11090 11320 +230
- Misses 2013 2014 +1
- Partials 264 267 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…o add/sketch_fromfile
ok, I think the functionality here is largely done and at a good resting place. It's a bit of a monster PR and while I do have ideas on where to take the functionality next (AS DOES TESSA I'M SURE), I think it might be good to get this reviewed. So, ready for review @sourmash-bio/devs ! |
sourmash sketch fromfile
sourmash sketch fromfile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 🎉
Note: PR into #1907.
This PR creates a
sourmash sketch fromfile
command to support large-scale/batch construction of signatures.Addresses #1671.
Fixes #1634.
TODO:
fromfile
fromfile
format? or just say 'other columns ignored'--output-csv
--singleton
interact with fromfile? not currently implemented? consider implementingsourmash sketch fromfile --singleton
mode. #1919