Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable injecting manifest into chunks. #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sunyang713
Copy link

Addresses #47, #48, #49, #50.

@mbrevda
Copy link

mbrevda commented Sep 12, 2017

@diurnalist would this patch work?

@chaffeqa
Copy link

I can confirm this fixes at least my dev env

@chaffeqa
Copy link

chaffeqa commented Oct 24, 2017

Update here, that line is actually required when using NamedModulesPlugin.

I think the solution is to combine #37, #53 and change this to:

if (!inlineManifest) {
    chunk.files.push(manifestFilename);
}

Edit: I think jouni-kantola/inline-chunk-manifest-html-webpack-plugin#17 (comment) is dependent on this FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants