This repository has been archived by the owner on Jun 8, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
Fork dependency plugin to enable independent updates #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jouni-kantola
force-pushed
the
fork-chunk-manifest-webpack-plugin
branch
from
October 28, 2017 04:37
e6c8dcf
to
581d0eb
Compare
jouni-kantola
force-pushed
the
fork-chunk-manifest-webpack-plugin
branch
from
October 28, 2017 09:40
2b0b764
to
97a5d54
Compare
This was referenced Oct 28, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forked
chunk-manifest-webpack-plugin
and removed the plugin's redundant chunk manifest inlining.Also:
inline-chunk-manifest-html-webpack-plugin
was referenced inchunk-manifest-plugin
's issues Upgrading to v1.1.2 break inlining the manifest in HTML soundcloud/chunk-manifest-webpack-plugin#48 and 1.1.2 outputs .json file instead of .js file soundcloud/chunk-manifest-webpack-plugin#47. The fork handles these issues by same solution as PR Disable injecting manifest into chunks. soundcloud/chunk-manifest-webpack-plugin#52.class
webpack
as peer dependencyAddresses issues: #16 and #13.
Not in this PR, but forking enables further work to independent of updates of
chunk-manifest-webpack-plugin
, i.e. #14.