-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Escape pipe char of commit msg in markdown table #515
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -345,6 +345,34 @@ describe('getCommentBody', () => { | |
targetPullRequestStates: [], | ||
}, | ||
}, | ||
{ | ||
formatted: 'some-formatted-text', | ||
commit: { | ||
author: { | ||
email: '[email protected]', | ||
name: 'Matthias Polman-Wilhelm', | ||
}, | ||
sourceBranch: 'master', | ||
sourcePullRequest: { | ||
labels: [], | ||
number: 44, | ||
title: 'Antarctica commit | with pipeline char', | ||
url: 'url-to-pr-45', | ||
mergeCommit: { | ||
sha: '', | ||
message: 'Antarctica commit | with pipeline char', | ||
}, | ||
}, | ||
suggestedTargetBranches: [], | ||
sourceCommit: { | ||
branchLabelMapping: {}, | ||
committedDate: '', | ||
sha: '', | ||
message: 'Antarctica commit | with pipeline char', | ||
}, | ||
targetPullRequestStates: [], | ||
}, | ||
}, | ||
], | ||
}), | ||
}, | ||
|
@@ -365,27 +393,27 @@ describe('getCommentBody', () => { | |
it('posts a comment when `publishStatusCommentOnFailure = true`', () => { | ||
const params = getParams({ publishStatusCommentOnFailure: true }); | ||
expect(getCommentBody(params)).toMatchInlineSnapshot(` | ||
"## 💔 Some backports could not be created | ||
"## 💔 Some backports could not be created | ||
|
||
| Status | Branch | Result | | ||
|:------:|:------:|:------| | ||
|✅|7.x|[<img src="https://img.shields.io/github/pulls/detail/state/elastic/kibana/55">](url-to-pr-55)| | ||
|❌|7.1|**Backport failed because of merge conflicts**<br><br>You might need to backport the following PRs to 7.1:<br> - [New Zealand commit message](url-to-pr-5)<br> - [Australia commit](url-to-pr-44)| | ||
|❌|7.2|Backport failed because of merge conflicts| | ||
| Status | Branch | Result | | ||
|:------:|:------:|:------| | ||
|✅|7.x|[<img src="https://img.shields.io/github/pulls/detail/state/elastic/kibana/55">](url-to-pr-55)| | ||
|❌|7.1|**Backport failed because of merge conflicts**<br><br>You might need to backport the following PRs to 7.1:<br> - [New Zealand commit message](url-to-pr-5)<br> - [Australia commit](url-to-pr-44)<br> - [Antarctica commit \\| with pipeline char](url-to-pr-45)| | ||
|❌|7.2|Backport failed because of merge conflicts| | ||
|
||
Note: Successful backport PRs will be merged automatically after passing CI. | ||
Note: Successful backport PRs will be merged automatically after passing CI. | ||
|
||
### Manual backport | ||
To create the backport manually run: | ||
\`\`\` | ||
node scripts/backport --pr 55 | ||
\`\`\` | ||
### Manual backport | ||
To create the backport manually run: | ||
\`\`\` | ||
node scripts/backport --pr 55 | ||
\`\`\` | ||
|
||
### Questions ? | ||
Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) | ||
### Questions ? | ||
Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) | ||
|
||
<!--- Backport version: 1.2.3-mocked -->" | ||
`); | ||
<!--- Backport version: 1.2.3-mocked -->" | ||
`); | ||
}); | ||
|
||
it('does not post a comment when `publishStatusCommentOnFailure = false`', () => { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding High
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sorenlouv I don't know why this is raised, looked around but didn't find answers, IMO opinion this should be correct in Markdown, I don't know why this is a failure?