Escape pipe char of commit msg in markdown table #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| })`; | ||
| const msg = getFirstLine(c.commit.sourceCommit.message); | ||
| // make sure to escape the pipe character to ensure the markdown table is correct | ||
| const msgEscaped = msg.replace(/\|/g, '\\|'); |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding High
There was a problem hiding this comment.
@sorenlouv I don't know why this is raised, looked around but didn't find answers, IMO opinion this should be correct in Markdown, I don't know why this is a failure?
|
lgtm. Any thoughts on the codeql warning? |
|
@sorenlouv didn't have time, but will have a look, and then flag it as ready for review 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a commit message contains a
|character, this breaks the "All backports failed" comment in GitHub, due to the|character is part of the table markdown. With this PR|is escaped with\|to ensure the commit message and link are displayed correctlyresolves #512