Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.16: CI: add check for explicit spl-token-cli version (backport of #34430) #34464

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 14, 2023

This is an automatic backport of pull request #34430 done by Mergify.

Fixes #34429


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Add script to specify spl-token-cli version

* Add check for spl-token-cli version to CI

* Add minor release branch cleanup instruction to unblock CI on the new stable branch

---------

Co-authored-by: Will Hickey <[email protected]>
(cherry picked from commit e6e191f)
@CriesofCarrots
Copy link
Contributor

Going to push a commit with the actual version

yihau
yihau previously approved these changes Dec 14, 2023
@CriesofCarrots
Copy link
Contributor

CriesofCarrots commented Dec 14, 2023

Actually @yihau , I'm going to force push with that commit removed again to ensure that CI actually fails. I'll re-request review afterward. Sorry for the hassle!

@CriesofCarrots
Copy link
Contributor

Hooray! https://buildkite.com/solana-labs/solana/builds/105625#018c6962-2597-4813-a86b-fbdce5689b72

@CriesofCarrots CriesofCarrots requested a review from yihau December 14, 2023 17:39
Copy link
Member

@yihau yihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩

@CriesofCarrots CriesofCarrots added the automerge Merge this Pull Request automatically once CI passes label Dec 14, 2023
@mergify mergify bot merged commit e4e043c into v1.16 Dec 14, 2023
13 checks passed
@mergify mergify bot deleted the mergify/bp/v1.16/pr-34430 branch December 14, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants