Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update the rust version for 1.16.23 in scripts #34481

Closed
wants to merge 1 commit into from

Conversation

rayanebel
Copy link

Problem

When I try to build a docker image for solana 1.16.23 with the following script ./sdk/docker-solana/build.sh I get compilation errors.

error[E0658]: use of unstable library feature 'once_cell'
  --> /home/.cargo/registry/src/github.com-1ecc6299db9ec823/solana_rbpf-0.8.0/src/vm.rs:31:33
   |
31 | static RUNTIME_ENVIRONMENT_KEY: std::sync::OnceLock<i32> = std::sync::OnceLock::<i32>::new();
   |                                 ^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #74465 <https://github.com/rust-lang/rust/issues/74465> for more information
   
Some errors have detailed explanations: E0599, E0658.
For more information about an error, try `rustc --explain E0599`.
error: could not compile `solana_rbpf` due to 12 previous errors
warning: build failed, waiting for other jobs to finish...
error: failed to compile `spl-token-cli v3.3.0`, intermediate artifacts can be found at `/tmp/cargo-installPixazg`
Error: Process completed with exit code 101.

After looking to the commits history, I think we have to cherry-pick the following commit : f9b96fa and backport those changes in the 1.16.23

Summary of Changes

@mergify mergify bot added community Community contribution need:merge-assist labels Dec 15, 2023
@mergify mergify bot requested a review from a team December 15, 2023 11:09
@CriesofCarrots
Copy link
Contributor

Sorry, we won't risk bumping the rust version on our stable branch.

However, the issue is fixed as of #34464, which pins the spl-token-cli version to one that's compatible with the specified rust version.
That commit will be in v1.16.24, or you can cherry-pick it to your branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution need:merge-assist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants