Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: agave v2 rpc: replace getStakeActivation with rpc-client-extension #3591

Conversation

buffalojoec
Copy link
Contributor

@buffalojoec buffalojoec commented Nov 18, 2024

Draft implementation of replacing getStakeActivation with the extension API over at https://github.com/anza-xyz/solana-rpc-client-extensions.

This is just to show what it would look like if we consumed the API directly. We also may have to reimplement the code, considering the dependency on web3.js.

Copy link

changeset-bot bot commented Nov 18, 2024

⚠️ No Changeset found

Latest commit: 6c617b9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@buffalojoec
Copy link
Contributor Author

buffalojoec commented Nov 18, 2024

@steveluscher is there any JS magic we can use to allow a circular dependency?
https://github.com/anza-xyz/solana-rpc-client-extensions/blob/aed9a86988f7f8055fe3dd3cd3e28761ad10ce04/js-v1/package.json#L51

If we can, and we want to support this, I'll need to make a change to the extension library to allow commitment and minContextSlot arguments. However, epoch is just not going to be possible, since you can't get that information for previous epochs via RPC anymore.

@steveluscher
Copy link
Collaborator

This is a good start: anza-xyz/solana-rpc-client-extensions#17

There need not be a concrete dependency on legacy web3.js at all. After anza-xyz/solana-rpc-client-extensions#17, the only use of @solana/web3.js in that module are in type positions.

I think maybe you can figure the rest of it out? It'll have something to do with something something dependencies something something.

@buffalojoec buffalojoec force-pushed the 11-18-feat_agave_v2_rpc_replace_getstakeactivation_with_rpc-client-extension branch from a6ad79a to 6c617b9 Compare November 26, 2024 07:47
Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants