feat: Agave v2 RPC: replace getConfirmedTransaction with getTransaction
#3418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Oct 23, 2024
buffalojoec
force-pushed
the
10-23-feat_agave_v2_rpc_replace_getconfirmedblock_with_getblock_
branch
from
2fe2282 to
6acd1dc
Compare
buffalojoec
force-pushed
the
10-23-feat_agave_v2_rpc_replace_getconfirmedtransaction_with_gettransaction_
branch
from
950dba5 to
ee67085
Compare
buffalojoec
force-pushed
the
10-23-feat_agave_v2_rpc_replace_getconfirmedblock_with_getblock_
branch
from
6acd1dc to
22a65a5
Compare
buffalojoec
force-pushed
the
10-23-feat_agave_v2_rpc_replace_getconfirmedtransaction_with_gettransaction_
branch
from
ee67085 to
f96e4d2
Compare
lorisleiva
previously approved these changes
Oct 29, 2024
mcintyre94
previously approved these changes
Oct 29, 2024
buffalojoec
force-pushed
the
10-23-feat_agave_v2_rpc_replace_getconfirmedblock_with_getblock_
branch
from
22a65a5 to
77b6e59
Compare
buffalojoec
force-pushed
the
10-23-feat_agave_v2_rpc_replace_getconfirmedtransaction_with_gettransaction_
branch
from
f96e4d2 to
1dbecf8
Compare
buffalojoec
force-pushed
the
10-23-feat_agave_v2_rpc_replace_getconfirmedblock_with_getblock_
branch
from
77b6e59 to
c35251a
Compare
buffalojoec
force-pushed
the
10-23-feat_agave_v2_rpc_replace_getconfirmedtransaction_with_gettransaction_
branch
from
1dbecf8 to
ac08a16
Compare
buffalojoec
force-pushed
the
10-23-feat_agave_v2_rpc_replace_getconfirmedblock_with_getblock_
branch
from
c35251a to
6607d91
Compare
buffalojoec
force-pushed
the
10-23-feat_agave_v2_rpc_replace_getconfirmedtransaction_with_gettransaction_
branch
from
ac08a16 to
e23d27c
Compare
buffalojoec
force-pushed
the
10-23-feat_agave_v2_rpc_replace_getconfirmedblock_with_getblock_
branch
from
6607d91 to
e730045
Compare
buffalojoec
force-pushed
the
10-23-feat_agave_v2_rpc_replace_getconfirmedtransaction_with_gettransaction_
branch
from
e23d27c to
e71da6f
Compare
steveluscher
previously approved these changes
Dec 15, 2024
Merge activity
|
buffalojoec
changed the base branch from
10-23-feat_agave_v2_rpc_replace_getconfirmedblock_with_getblock_
to
graphite-base/3418
buffalojoec
changed the base branch from
graphite-base/3418
to
maintenance/v1.x
buffalojoec
dismissed
steveluscher’s stale review
The base branch was changed.
buffalojoec
dismissed stale reviews from mcintyre94 and lorisleiva
The base branch was changed.
buffalojoec
force-pushed
the
10-23-feat_agave_v2_rpc_replace_getconfirmedtransaction_with_gettransaction_
branch
from
e71da6f to
3065292
Compare
|
A preview of the GitHub Pages site based on this PR is now available here: |
buffalojoec
deleted the
10-23-feat_agave_v2_rpc_replace_getconfirmedtransaction_with_gettransaction_
branch
|
🎉 This PR is included in version 1.97.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
With the upcoming upgrade from 1.18 to 2.0 on Solana mainnet-beta, deprecated RPC methods have been removed, therefore they will no longer be available through Web3.js client requests.
The Agave 2.0 Migration Guide lists semi-equivalent RPC method counterparts for each of the removed methods.
Summary of Changes
Replace
getConfirmedTransactionwithgetTransaction. This method was already requiring a confirmation level ofconfirmedorfinalized, so the behavior should be unchanged.