Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dependencies out of devDependencies where they are used in the implementation #2375

Conversation

steveluscher
Copy link
Collaborator

@steveluscher steveluscher commented Mar 23, 2024

Discovered these by running compile:js in each individual package, doing a git clean -dfx . between each.

Copy link

changeset-bot bot commented Mar 23, 2024

⚠️ No Changeset found

Latest commit: b6490a7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator Author

steveluscher commented Mar 23, 2024

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] Transitive: environment +12 331 kB rickhanlonii
npm/[email protected] None +5 108 kB simenb
npm/[email protected] Transitive: environment, filesystem, unsafe +27 565 kB simenb
npm/[email protected] None +7 328 kB romgain
npm/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +139 10 MB simenb
npm/[email protected] Transitive: eval +8 182 kB ljharb

🚮 Removed packages: npm/@solana/[email protected], npm/@solana/[email protected], npm/@solana/[email protected], npm/@solana/[email protected], npm/@solana/[email protected], npm/@solana/[email protected], npm/@solana/[email protected], npm/@solana/[email protected], npm/@solana/[email protected], npm/@solana/[email protected], npm/@solana/[email protected], npm/@solana/[email protected], npm/@solana/[email protected], npm/@solana/[email protected], npm/@solana/[email protected], npm/@solana/[email protected], npm/@solana/[email protected], npm/@solana/[email protected], npm/@solana/[email protected], npm/@solana/[email protected], npm/@solana/[email protected], npm/@solana/[email protected], npm/@solana/[email protected], npm/@solana/[email protected], npm/@solana/[email protected], npm/@solana/[email protected], npm/@solana/[email protected], npm/@solana/[email protected], npm/@solana/[email protected], npm/@solana/[email protected]

View full report↗︎

Copy link
Collaborator Author

steveluscher commented Mar 23, 2024

Merge activity

@steveluscher steveluscher merged commit 94f2053 into master Mar 23, 2024
8 checks passed
@steveluscher steveluscher deleted the 03-23-move_dependencies_out_of_devdependencies_where_they_are_used_in_the_implementation branch March 23, 2024 01:30
Copy link
Contributor

🎉 This PR is included in version 1.91.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant