-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Since tests depend on _implementations_, make sure to build upstreams before running tests #2373
Conversation
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @steveluscher and the rest of your teammates on Graphite |
@@ -88,12 +89,12 @@ | |||
"outputs": [] | |||
}, | |||
"test:unit:browser": { | |||
"dependsOn": ["compile:js"], | |||
"dependsOn": ["^compile:js"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now, if you run the tests fresh in, say, @solana/signers
where one of the tests depends on @solana/addresses
, you'll be sure to have @solana/addresses
built first so that it can be used in the test.
7b51add
to
ad66d3b
Compare
Merge activity
|
… before running tests
ad66d3b
to
36459be
Compare
🎉 This PR is included in version 1.91.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
No description provided.