Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Since tests depend on _implementations_, make sure to build upstreams before running tests #2373

Conversation

steveluscher
Copy link
Collaborator

No description provided.

Copy link

changeset-bot bot commented Mar 23, 2024

⚠️ No Changeset found

Latest commit: 36459be

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator Author

steveluscher commented Mar 23, 2024

@@ -88,12 +89,12 @@
"outputs": []
},
"test:unit:browser": {
"dependsOn": ["compile:js"],
"dependsOn": ["^compile:js"],
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, if you run the tests fresh in, say, @solana/signers where one of the tests depends on @solana/addresses, you'll be sure to have @solana/addresses built first so that it can be used in the test.

@steveluscher steveluscher changed the base branch from master to 03-23-move_dependencies_out_of_devdependencies_where_they_are_used_in_the_implementation March 23, 2024 01:17
@steveluscher steveluscher force-pushed the 03-23-since_tests_depend_on__implementations__make_sure_to_build_upstreams_before_running_tests branch from 7b51add to ad66d3b Compare March 23, 2024 01:17
Copy link
Collaborator Author

steveluscher commented Mar 23, 2024

Merge activity

  • Mar 22, 6:30 PM PDT: @steveluscher started a stack merge that includes this pull request via Graphite.
  • Mar 22, 6:31 PM PDT: Graphite rebased this pull request as part of a merge.
  • Mar 22, 6:32 PM PDT: @steveluscher merged this pull request with Graphite.

Base automatically changed from 03-23-move_dependencies_out_of_devdependencies_where_they_are_used_in_the_implementation to master March 23, 2024 01:30
@steveluscher steveluscher force-pushed the 03-23-since_tests_depend_on__implementations__make_sure_to_build_upstreams_before_running_tests branch from ad66d3b to 36459be Compare March 23, 2024 01:31
@steveluscher steveluscher merged commit 4402f35 into master Mar 23, 2024
7 checks passed
@steveluscher steveluscher deleted the 03-23-since_tests_depend_on__implementations__make_sure_to_build_upstreams_before_running_tests branch March 23, 2024 01:32
Copy link
Contributor

🎉 This PR is included in version 1.91.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant