fix: expand server settings returned by LanguageClientMiddleware [HEAD-975]
#392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`LanguageClientMiddleware` includes new attributes such as `deviceId`, `integrationName`, and `integrationVersion` to align with the initialization options. BREAKING CHANGE: The middleware now requires a `User` object to be instantiated.
cat2608
commented
Nov 16, 2023
|
nitpick: Please update the changelog :) |
`ServerSettings` includes user-specific attributes such as `integrationName`, `integrationVersion`, `automaticAuthentication`, and `deviceId`. This change consolidates all configuration-related options into a single `ServerSettings` structure. BREAKING CHANGE: The `fromConfiguration` method in `LanguageServerSettings` now requires `User` object. All consumers of `ServerSettings` must now expect the additional user-specific properties.
Reworked ServerSettings to enhance clarity and logical grouping of configuration properties. Added `defaultToTrue` utility function to handle undefined feature flags, defaulting them to 'true' and ensuring consistent server settings initialization.
cat2608
commented
Nov 17, 2023
Comment on lines
+3
to
+4
| ## [1.26.1] | ||
|
|
There was a problem hiding this comment.
I'm not sure about this version 🤔 Where can I validate it?
There was a problem hiding this comment.
It should be the next version (minor) after the currently released.
4 tasks
bastiandoetsch
approved these changes
Nov 20, 2023
bastiandoetsch
deleted the
fix/HEAD-975-expand-server-settings-middleware
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LanguageClientMiddlewareincludes new attributes such asdeviceId,integrationName, andintegrationVersionto align with the initialization options.BREAKING CHANGE: The middleware now requires a
Userobject to be instantiated.Checklist