feat: add report analytics settings [HEAD-975] #394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cat2608
commented
Nov 18, 2023
Comment on lines
24
to
+27
| // Reporting and telemetry | ||
| sendErrorReports?: string; | ||
| enableTelemetry?: string; | ||
| enableAnalytics?: boolean; |
There was a problem hiding this comment.
I'm not really sure why the other flags are handled as string. I decided to handle enableAnalytics as boolean but more than happy to change to string if that's the correct way :)
There was a problem hiding this comment.
A historical flaw/bug - using boolean here is correct.
Introduced `yesAnalyticsReport` flag to allow users to opt-in or opt-out of analytics reporting. This setting is added to `package.json` for visibility in VS Code UI and integrated into the `IConfiguration` interface.
cat2608
force-pushed
the
feat/HEAD-975-add-report-analytics-flag
branch
from
dea4974 to
13d2868
Compare
|
Change not relevant now 👋 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the analytics flag.
yesAnalyticsReportenables users to opt-in to analytics reporting. This setting allows the extension to collect usage statistics to help improve the product.Note: this is a continuation from #392. You can dismiss #392 changes by looking at the commits of this branch. Please merge that first :)
Checklist
Screenshots / GIFs