Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: send analytics after scans by calling the CLI #252

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

bastiandoetsch
Copy link
Contributor

@bastiandoetsch bastiandoetsch commented Nov 16, 2023

Description

Provide description of this PR and changes, if linked Jira ticket doesn't cover it in full.

Checklist

  • Tests added and all succeed
  • Linted
  • CHANGELOG.md updated
  • README.md updated, if user-facing

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

chore: use log-prefix, remove assertion for resilience in tests

fix: also fix the test

fix: archs again

fix: sync arch values with what LS is sending

refactor: change called analytics command

- use `--experimental`
- use `analytics report` as command

This needs an update from Go Application Framework to actually report

fix: implement PR suggestions

- convert JSON correctly into snake_case
- use architecture from operating system
- log output of CLI command
- escape the payload for the command line

chore: remove old comment

refactor: use collection initializer

docs: add CHANGELOG.md entry

fix: stupid error

fix: tests and injection

feat: add tests

feat: send analytics after scans by calling the CLI
@bastiandoetsch bastiandoetsch merged commit a7b79c6 into main Nov 22, 2023
2 checks passed
@bastiandoetsch bastiandoetsch deleted the feat/HEAD-921-vs-ls branch November 22, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants