Skip to content

Commit

Permalink
chore: use log-prefix, remove assertion for resilience in tests
Browse files Browse the repository at this point in the history
  • Loading branch information
bastiandoetsch committed Nov 22, 2023
1 parent 7e99f87 commit 0dcb4ae
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion Snyk.VisualStudio.Extension.Shared/CLI/SnykCli.cs
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ public async Task ReportAnalyticsAsync(string data)
BuildScanEnvironmentVariables());

var result = ConsoleRunner.Execute();
if (result.Length > 0) Logger.Warning("Unexpected output: {Result}", result);
if (result.Length > 0) Logger.Warning("ReportAnalyticsAsync: Unexpected output: {Result}", result);
}

private string GetCliPath()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ public void SnykIdeAnalyticsServiceTest_shouldCreateTheCorrectPayloadString()
Assert.Contains("\"application\":\"application\"", payload);
Assert.Contains("\"application_version\":\"1.0.0\"", payload);
Assert.Contains("\"os\":\"windows\"", payload);
Assert.Contains("\"arch\":\"x86_64\"", payload);
Assert.Contains("\"integration_name\":\"integrationName\"", payload);
Assert.Contains("\"integration_version\":\"1.0.0\"", payload);
Assert.Contains("\"integration_environment\":\"integrationEnvironment\"", payload);
Expand Down

0 comments on commit 0dcb4ae

Please sign in to comment.