Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use conda instead of mamba by default #70

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use conda instead of mamba by default #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions snakedeploy/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,9 +129,9 @@ def get_parser():
)
pin_conda_envs.add_argument(
"--conda-frontend",
choices=["mamba", "conda"],
default="mamba",
help="Conda frontend to use (default: mamba).",
choices=["conda", "mamba"],
default="conda",
help="Conda frontend to use (default: conda).",
Comment on lines +132 to +134
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Inconsistent default frontend settings need to be aligned

The codebase has inconsistent default frontend settings:

  • pin-conda-envs subcommand uses "conda" as default
  • update-conda-envs subcommand still uses "mamba" as default

This inconsistency should be addressed to maintain a uniform default frontend across all commands.

🔗 Analysis chain

LGTM! Verify impact on existing workflows.

The changes correctly implement the switch to conda as the default frontend while maintaining backwards compatibility by keeping mamba as an option.

Let's verify if there are any hardcoded references to the default frontend in tests or documentation:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for any hardcoded references to mamba or conda as the default frontend
rg -i "default.*(?:mamba|conda)" --type md --type rst --type py

Length of output: 315

Script:

#!/bin/bash
# Let's check the context of the second occurrence of mamba as default
rg -B 5 -A 5 'default="mamba"' snakedeploy/client.py

Length of output: 417

)
pin_conda_envs.add_argument(
"--create-prs",
Expand Down
Loading