fix: use conda instead of mamba by default #70
Conversation
📝 WalkthroughWalkthroughThe changes in this pull request focus on the command-line argument parser within the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant CLI
participant Snakedeploy
User->>CLI: Execute pin-conda-envs with --conda-frontend
CLI->>Snakedeploy: Process command with specified frontend
Snakedeploy-->>CLI: Return success or error
CLI-->>User: Display result
sequenceDiagram
participant User
participant CLI
participant Snakedeploy
User->>CLI: Execute update-conda-envs with --conda-frontend
CLI->>Snakedeploy: Process command with specified frontend
Snakedeploy-->>CLI: Return success or error
CLI-->>User: Display result
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
snakedeploy/client.py (1)
Line range hint
179-183: Fix inconsistent default frontend inupdate-conda-envs.While
pin-conda-envshas been updated to use conda as the default frontend,update-conda-envsstill shows mamba as the default. This inconsistency should be fixed to align with the PR's objective.Apply this diff to maintain consistency:
update_conda_envs.add_argument( "--conda-frontend", - choices=["mamba", "conda"], - default="mamba", - help="Conda frontend to use (default: mamba).", + choices=["conda", "mamba"], + default="conda", + help="Conda frontend to use (default: conda).", )
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
snakedeploy/client.py(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
snakedeploy/client.py (1)
Pattern **/*.py: Do not try to improve formatting.
Do not suggest type annotations for functions that are defined inside of functions or methods.
Do not suggest type annotation of the self argument of methods.
Do not suggest type annotation of the cls argument of classmethods.
Do not suggest return type annotation if a function or method does not contain a return statement.
| choices=["conda", "mamba"], | ||
| default="conda", | ||
| help="Conda frontend to use (default: conda).", |
There was a problem hiding this comment.
💡 Codebase verification
Inconsistent default frontend settings need to be aligned
The codebase has inconsistent default frontend settings:
pin-conda-envssubcommand uses "conda" as defaultupdate-conda-envssubcommand still uses "mamba" as default
This inconsistency should be addressed to maintain a uniform default frontend across all commands.
🔗 Analysis chain
LGTM! Verify impact on existing workflows.
The changes correctly implement the switch to conda as the default frontend while maintaining backwards compatibility by keeping mamba as an option.
Let's verify if there are any hardcoded references to the default frontend in tests or documentation:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for any hardcoded references to mamba or conda as the default frontend
rg -i "default.*(?:mamba|conda)" --type md --type rst --type py
Length of output: 315
Script:
#!/bin/bash
# Let's check the context of the second occurrence of mamba as default
rg -B 5 -A 5 'default="mamba"' snakedeploy/client.py
Length of output: 417
Summary by CodeRabbit
New Features
--conda-frontendargument options forpin-conda-envsandupdate-conda-envscommands to includecondaas the default choice.Bug Fixes
--tagor--branchduring thedeploy-workflowcommand.