Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest generated changes #50

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions src/connectors/asana/functions/create_task.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ export default DefineConnector({
properties: {
workspace_gid: { type: Schema.types.string, title: "Workspace" },
project: { type: Schema.types.string, title: "Project" },
assignee_section: { type: Schema.types.string, title: "Section" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is a breaking change too; if a workflow provides the assignee_section to this function, what would happen?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yess this may cause some breaking changes

assignee: {
type: Schema.slack.types.user_id,
description: "Select a user",
Expand Down Expand Up @@ -43,13 +42,7 @@ export default DefineConnector({
title: "Asana Access Token",
},
},
required: [
"workspace_gid",
"project",
"assignee",
"name",
"asana_access_token",
],
required: ["workspace_gid", "project", "name", "asana_access_token"],
},
output_parameters: {
properties: {
Expand Down
3 changes: 0 additions & 3 deletions src/connectors/asana/functions/create_task_test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ Deno.test("CreateTask can be used as a Slack function in a workflow step", () =>
testWorkflow.addStep(CreateTask, {
workspace_gid: "test",
project: "test",
assignee: "test",
name: "test",
asana_access_token: "test",
});
Expand All @@ -22,7 +21,6 @@ Deno.test("CreateTask can be used as a Slack function in a workflow step", () =>
assertEquals(actual.inputs, {
workspace_gid: "test",
project: "test",
assignee: "test",
name: "test",
asana_access_token: "test",
});
Expand All @@ -37,7 +35,6 @@ Deno.test("All outputs of Slack function CreateTask should exist", () => {
const step = testWorkflow.addStep(CreateTask, {
workspace_gid: "test",
project: "test",
assignee: "test",
name: "test",
asana_access_token: "test",
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,13 @@ export default DefineConnector({
},
notify_teams: {
type: Schema.types.array,
description: "Please select an option",
description: "Please select one or many teams",
title: "Notify team",
items: { type: Schema.types.string },
},
notify_members: {
type: Schema.types.array,
description: "Enter user IDs",
description: "Please select one or many members",
title: "Notify reviewers",
items: { type: Schema.types.string },
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { Schema } from "../../../deps.ts";

export default DefineConnector({
callback_id: "A05RF94AFB3#/functions/create_feature_flag",
title: "Create a feature flag",
title: "Create a boolean feature flag",
input_parameters: {
properties: {
project_key: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export default DefineConnector({
},
target_key: {
type: Schema.types.array,
description: "Enter text",
description: "Please add one or more target keys",
title: "Target key",
items: { type: Schema.types.string },
},
Expand Down
8 changes: 7 additions & 1 deletion src/connectors/loopio/functions/create_project.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,13 @@ export default DefineConnector({
enum: ["RFP", "RFI", "DDQ", "SQ", "PP", "OTHER"],
},
},
required: ["project_name", "company_name", "due_date", "project_type"],
required: [
"project_name",
"company_name",
"owner",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a breaking change

"due_date",
"project_type",
],
},
output_parameters: {
properties: {
Expand Down
3 changes: 3 additions & 0 deletions src/connectors/loopio/functions/create_project_test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ Deno.test("CreateProject can be used as a Slack function in a workflow step", ()
testWorkflow.addStep(CreateProject, {
project_name: "test",
company_name: "test",
owner: "test",
due_date: "test",
project_type: "test",
});
Expand All @@ -21,6 +22,7 @@ Deno.test("CreateProject can be used as a Slack function in a workflow step", ()
assertEquals(actual.inputs, {
project_name: "test",
company_name: "test",
owner: "test",
due_date: "test",
project_type: "test",
});
Expand All @@ -35,6 +37,7 @@ Deno.test("All outputs of Slack function CreateProject should exist", () => {
const step = testWorkflow.addStep(CreateProject, {
project_name: "test",
company_name: "test",
owner: "test",
due_date: "test",
project_type: "test",
});
Expand Down
2 changes: 1 addition & 1 deletion src/connectors/mod.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/** This file was autogenerated on Mon Jun 17 2024. Follow the steps in src/schema/slack/functions/README.md to rebuild **/
/** This file was autogenerated on Mon Jun 24 2024. Follow the steps in src/schema/slack/functions/README.md to rebuild **/
import AdobeSign from "./adobe.sign/mod.ts";
import Airtable from "./airtable/mod.ts";
import Asana from "./asana/mod.ts";
Expand Down
Loading