Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest generated changes #50

Closed
wants to merge 2 commits into from
Closed

Conversation

github-actions[bot]
Copy link
Contributor

🚀 Automated Pull Request: Coded-Connectors Update

This PR brings the latest changes to coded-connectors, fueled by Slack's latest data. Developers can now access the newest features effortlessly.

GitHub prevents triggering a workflow from a workflow, the checks on this pull request will not be triggered automatically 😅
To trigger the checks on this pull request:

  1. close the pull request
  2. reopen the pull request

Github-Actions 🤖

@github-actions github-actions bot added the enhancement New feature or request label Jun 24, 2024
@github-actions github-actions bot requested a review from a team as a code owner June 24, 2024 00:11
@filmaj filmaj closed this Jun 24, 2024
@filmaj filmaj reopened this Jun 24, 2024
Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's one, maybe two, breaking changes in here.

required: [
"project_name",
"company_name",
"owner",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a breaking change

@@ -9,7 +9,6 @@ export default DefineConnector({
properties: {
workspace_gid: { type: Schema.types.string, title: "Workspace" },
project: { type: Schema.types.string, title: "Project" },
assignee_section: { type: Schema.types.string, title: "Section" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is a breaking change too; if a workflow provides the assignee_section to this function, what would happen?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yess this may cause some breaking changes

@WilliamBergamin
Copy link
Collaborator

@filmaj these are breaking changes

I've asked internally if the changes are intended, if they are I will release them under a new major version

@WilliamBergamin
Copy link
Collaborator

@filmaj I did not get a response on if this is intended behavior 🤔

What do you think about merging this and cutting a major?

@filmaj
Copy link
Contributor

filmaj commented Jul 2, 2024

These changes are included in #51, so will close this in favour of #51.

@filmaj filmaj closed this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants