Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node Visualizer (Refactor) #89

Merged
merged 13 commits into from
Dec 22, 2024

Conversation

mrpalide
Copy link
Contributor

@mrpalide mrpalide commented Dec 22, 2024

Changes:

  • refactor node visualizer to a simple version, we need to improve it later but is good for now.
  • add changes of PR Maintain integration env #84 here.

Screen Record:

nv-refactor.mp4

@0pcom
Copy link
Collaborator

0pcom commented Dec 22, 2024

if this can be run outside of the source code / outside the dev environment, then go ahead and add it here:

https://github.com/skycoin/skywire-services/blob/develop/cmd/skywire-services/commands/root.go

I think we don't have it deployed currently, and I've never seen it deployed in the past.

However, it could be integrated with the reward system UI in the future just in an ad-hoc way. Like with a flag when running the reward system UI. I can probably just proxy it into the UI along a certain route like /node-visualizer - i will just link nv.skywire.dev in the reward system ui

Also we really need tests fixed here before much else is done, if possible.

...

Also, are those lines transports? If so, I think it's likely that many of those transports may not actually exist. Cross-reference the output of skywire cli tp tree

image

@mrpalide
Copy link
Contributor Author

mrpalide commented Dec 22, 2024

Yes, I'm on fix tests.

Actually, I want to add changes from this PR #84 to here, and fix tests issue.

@mrpalide mrpalide mentioned this pull request Dec 22, 2024
@mrpalide mrpalide merged commit c6c97b6 into skycoin:develop Dec 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants