Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain integration env #84

Closed
wants to merge 10 commits into from

Conversation

mrpalide
Copy link
Contributor

@mrpalide mrpalide commented Nov 3, 2024

Changes:

  • add missing dmsg-monitor service
  • fix docker scripts and Dockerfiles for get BUILD_ARCH in building integration or e2e test env as:
    make integration-env-build BUILD_ARCH=linux/arm64
    make e2e-build BUILD_ARCH=linux/arm64
    
    all architectures should work (not tested except arm64)
  • clean docker scripts from useless codes

@0pcom
Copy link
Collaborator

0pcom commented Dec 22, 2024

I believe the dmsg monitor needed to be re-implemented because this still assumes that every dmsg key is also a visor.

We need uptime tracking for dmsg-disc. And for TPD, and to eliminate separate uptime tracker.

If you want to integrate it as-is, just don't run the service on prod.

I think there is a better way to do this.

I've outlined as much in this ticket

skycoin/dmsg#291

@mrpalide
Copy link
Contributor Author

Closed, due to move changes here: #89

@mrpalide mrpalide closed this Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants