Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Allow removing named extensions in yaml config #10516

Merged
merged 1 commit into from
Sep 27, 2022
Merged

FIX Allow removing named extensions in yaml config #10516

merged 1 commit into from
Sep 27, 2022

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli linked an issue Sep 26, 2022 that may be closed by this pull request
Unsetting extensions from Yaml does not seem to work #10511
Closed
@GuySartorelli GuySartorelli changed the base branch from 4 to 4.11 September 26, 2022 23:47
@GuySartorelli GuySartorelli force-pushed the pulls/4.11/override-named-extension branch from 1c8ff0f to deea6ca Compare September 27, 2022 00:13
@GuySartorelli GuySartorelli force-pushed the pulls/4.11/override-named-extension branch from deea6ca to 4a598de Compare September 27, 2022 00:15
@GuySartorelli GuySartorelli marked this pull request as ready for review September 27, 2022 00:30
@GuySartorelli GuySartorelli mentioned this pull request Sep 27, 2022
Closed
michalkleiner
michalkleiner approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@michalkleiner michalkleiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible.

@michalkleiner michalkleiner merged commit b803090 into silverstripe:4.11 Sep 27, 2022
@GuySartorelli GuySartorelli deleted the pulls/4.11/override-named-extension branch September 27, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalkleiner michalkleiner michalkleiner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unsetting extensions from Yaml does not seem to work
2 participants
@GuySartorelli @michalkleiner